- Issue created by @anwar_max
- Issue was unassigned.
- Status changed to Needs review
4 months ago 6:40am 8 September 2024 - Status changed to Needs work
4 months ago 4:05pm 8 September 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
We can't just change this, we need to update the versions to a minimum of 10.2.0. See: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...
- Status changed to Needs review
4 months ago 5:50am 9 September 2024 - Assigned to atul_ghate
- Issue was unassigned.
- Status changed to RTBC
4 months ago 6:56am 9 September 2024 - 🇮🇳India atul_ghate
I have cloned this module and verified its functionality both before and after applying patch (MR6). It is working fine, so I am changing its status to RTBC. I have attached a video for reference.
- Status changed to Needs work
4 months ago 7:15am 9 September 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This is introducing PHPCS issues, so not ok to merge.
I personally prefer a info.yml change over this logic in the constructor, as even 10.2 is EOL (only getting security fixes for a few more months). So that would mean dropping support with everything below 10.2 which is fine. Maintainer can choose to put that on a different major/minor version tag (or even branch).
- Status changed to Needs review
4 months ago 5:17am 10 September 2024 - First commit to issue fork.
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Thanks for your contribution.
I have reverted `core_version_requirement` because the second parameter is optional for Drupal version < 10.2.0 -
gaurav_manerkar →
committed bf424754 on 8.x-1.x authored by
anwar_max →
Issue #3472835 by anwar_max, gaurav_manerkar, atul_ghate, bramdriesen:...
-
gaurav_manerkar →
committed bf424754 on 8.x-1.x authored by
anwar_max →
- Status changed to Fixed
4 months ago 6:06am 11 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.
