- Issue created by @lauriii
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I thought you were referring to
/admin/structure/component😅 This subtle title tweak clarifies that for me 😇 - Assigned to fazilitehreem
- Merge request !242#3471154: Handled delete component with delete button → (Merged) created by fazilitehreem
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:44am 2 September 2024 - 🇫🇮Finland lauriii Finland
Thank you @fazilitehreem! It would be great if we could add test coverage for this.
- First commit to issue fork.
- Assigned to jessebaker
Since this is a part of milestone 🌱 Milestone 0.1.0: Experience Builder Demo Active so assigning it to @jessebaker to get reviews.
- Assigned to fazilitehreem
- Issue was unassigned.
- Status changed to Needs work
3 months ago 1:53pm 4 September 2024 - 🇫🇮Finland lauriii Finland
The MR needs a rebase since a lot of MRs have landed
Adding video for reference that we can now delete selected components even if we click outside the iframe as well as if a component is selected via the page hierarchy display.
- Status changed to Needs review
3 months ago 3:08am 5 September 2024 - First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
AFAICT tests are present and passing now 👍
@jessebaker has pointed out an oversight over at https://git.drupalcode.org/project/experience_builder/-/merge_requests/2..., so marking .
In there, he also points out a scenario that is currently broken and that the test coverage should be expanded for.
Finally: please include a GIF showing this in action.
- Assigned to utkarsh_33
- Status changed to Needs work
3 months ago 12:19pm 5 September 2024 - Assigned to jessebaker
- Status changed to Needs review
3 months ago 12:21pm 5 September 2024 - Issue was unassigned.
- Status changed to Needs work
3 months ago 12:25pm 5 September 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
https://git.drupalcode.org/project/experience_builder/-/merge_requests/2... is not yet addressed.
Nor is the rest of #15.
- Assigned to fazilitehreem
- Issue was unassigned.
- Status changed to Needs review
3 months ago 1:27pm 5 September 2024 - Status changed to Needs work
3 months ago 1:49pm 5 September 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Tests aren't passing.
🙏 Please don't mark an issue as needing review until the MR passes tests!
- Assigned to jessebaker
- Status changed to Needs review
3 months ago 2:15pm 5 September 2024 -
jessebaker →
committed e807bfbc on 0.x authored by
fazilitehreem →
Issue #3471154 by utkarsh_33, fazilitehreem, jessebaker: Allow deleting...
-
jessebaker →
committed e807bfbc on 0.x authored by
fazilitehreem →
- Issue was unassigned.
- Status changed to Fixed
3 months ago 2:18pm 5 September 2024 - 🇫🇮Finland lauriii Finland
Yay!! Great work everyone! 👏 🎉 Makes deleting components from a page so much easier 🤩
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Just tested with latest changes and it works great, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
