- Issue created by @mondrake
- Status changed to Needs review
4 months ago 8:23am 29 August 2024 - 🇫🇷France andypost
Looks good but probably needs 12.x issue to remove commented out type and
phpcs:disable
- 🇮🇹Italy mondrake 🇮🇹
Added followup 📌 Add return typehints for getWidth()/getHeigth in interfaces Postponed for D12 and @todo and @see in the MR to mimic what we'e doing in https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... →
- 🇫🇷France andypost
Thanks, looks ready except
phpcs:disable Drupal.Commenting
probably as docs said - Status changed to Needs work
4 months ago 2:13pm 5 September 2024 - 🇺🇸United States smustgrave
* : ?int */;
Not super familiar with examples like this but know I've seen it in parameters before.
Code wise believe this is good. But can a CR be added just in case there are some this may impact later.
- Status changed to Postponed
4 months ago 4:25pm 5 September 2024 - 🇮🇹Italy mondrake 🇮🇹
I think it's better wait on Symfony's [ErrorHandler] Add support for @return-type-will-change PR at this stage, that will provide a clear deprecation message for the need to introduce the typehint.
- 🇮🇹Italy mondrake 🇮🇹