DomainConfigOverrider is initializing every time, making it very slow

https://git.drupalcode.org/project/domain/-/merge_requests/95/diffs#58c9... was the same original code before PHPstan, but the replacement was OK instead of what this issue fixes, so maybe it was some accidental backspace or anything, but still worth understanding the automatic code fixing that went through the related issue.

Nice catch, @hanoii. LGTM, moving issue to RTBC status.

Great finding and well made report! +1 @hanoii

Thanks @davps for joining and trying to push things forward. But this needs more reviews. So please do not set to RTBC to quick before more users or contributors have taken a look at the fixes and report back that it works as expected. Because this is exactly the reason why issues like this occur otherwise.

This was an inadvertent added (by me) during the PHPStan issue fix.

Ah ok. +1

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.