Configure and fix PHPStan issues

webflo → changed the visibility of the branch 3458055-phpstan to hidden.

webflo → changed the visibility of the branch 3458055-phpstan to active.

webflo → changed the visibility of the branch 3458055-phpstan to hidden.

webflo → changed the visibility of the branch 3458055-phpstan to active.

I think I am going to dial back to level 1 PHPStan for now.

I think level 2 is achievable. We should create a baseline and refactor it step by step. Maybe one submodule after another.

Yes. I fixed my earlier problems and have been fixing things in reverse alphabetical order. Trying to finish up domain_config_ui today.

This is all looking good. I have moved the remaining issues into phpstan-baseline.neon.

@webflo -- I think those can be fixed in a separate issue.

This could use a real-world test, but if it works for you, then I feel good about the state of the code and adding new maintainers.

We fixed everything except Drush, which should be a separate issue.

The attached patch did not work as documented here -- https://www.drush.org/12.x/dependency-injection/#create-method -- using Druah 12.4 on PHP 8.3.

That can be a separate issue.

Automatically closed - issue fixed for 2 weeks with no activity.