Add EntityInterface return typehints to protected test helper methods

Seems straight forward.

Where would you say you are in being able to make this a hard requirement?

There are thousands of functions covered by the existing sibling issues, particularly the void one would knock out the most in one go. Then it looks like there are only a few hundred remaining.

After following the workflow in the IS grep find more instances to fix. They aren't recent additions either.

+  protected function createAnotherEntity($key): EntityInterface {
+  protected function createPrivateFile($file_name): EntityInterface|File {
+  protected function updateEntity(EntityInterface $entity, Row $row): EntityInterface {
+  protected function createAnotherEntity(): EntityInterface {
+  protected function createFile(): EntityInterface {

I fixed up createFile. I don't think we can do the others here.

• createAnotherEntity is in ResourceTestBase. Possibly we could fix it but it is extended a lot and it scares me.
• createPrivateFile returns a union type which I think we should not address here.
• updateEntity extends from runtime code \Drupal\migrate\Plugin\migrate\destination\Entity::updateEntity so is out of scope.

Know we got follow ups for unions but should there be others open for the other bullets.

The runtime one would not be in scope for this meta as it's for test only code.

The resource test base one I guess would fall under the "fix all remaining returns" part of the meta.

Thanks for confirming. Then this batch is probably good.

Committed to 11.x - thanks!

larowlan → closed merge request !9331

Automatically closed - issue fixed for 2 weeks with no activity.