TVI Admin Interface crashes when installed on Drupal 11

Hi @tomthorp

I have created a patch for Drupal 11 compatibility now. Thank you.

Thanks for the patch. However there are Symfony dependencies in TaxonomyViewsIntegratorManager (called ContainerAwareTrait & ContainerAwareInterface) that are no longer in Symfony 7.1 . ( See CallableResolver and ClassResolver no longer support ContainerAwareInterface → ). Can this be encompassed into the patch?

After much module testing, I now have a "working" TVI module on Drupal 11. The patch file is attached.

At this stage, the code has not gone through regression testing. If one of the module maintainers can do this at their earliest convenience, that would be great. (PS. I am a novice when it comes to Drupal module debugging / maintenance. So any pointers in this respect would be gladly appreciated.)

With #2 I still had some problems on my site but #4 resolves them for me.

damienmckenna → changed the visibility of the branch 3470314-tvi-admin-interface to hidden.

I created a MR from #4, and added a gitlab file so we can see how well the tests run.

The D11 changes appear to break D10..

The tests pass locally in DDEV but not in GitLab CI.

Fails under Drupal: 10.3.6-dev, passes under Drupal: 11-dev

Replicated locally, looks like this change is not D10.3 compatible:

https://git.drupalcode.org/issue/tvi-3470314/-/commit/ba741dab191fd7639d...

After removing the type, it passed. Re-running for D11.

Tests fail under Drupal 9.5 (previous major) due to a missing core test trait. Though I am not sure we care about an EOL version of Drupal (and I don't see many reports of Drupal 9 not working, this could be a test-only failure).

I think that was triggered from this in ConfigFormBase:

    if (!$typedConfigManager instanceof TypedConfigManagerInterface) {
      $type = get_debug_type($typedConfigManager);
      @trigger_error("Passing $type to the \$typedConfigManager parameter of ConfigFormBase::__construct() is deprecated in drupal:10.2.0 and must be an instance of \Drupal\Core\Config\TypedConfigManagerInterface in drupal:11.0.0. See https://www.drupal.org/node/3404140", E_USER_DEPRECATED);
    }

Tests now pass in D10 and D11

I think we are good here for D10 and 11.

General run through works on D10 (i.e. initial error described by OP). I think we are good to go here, thanks everyone!

Thanks @damienmckenna and @kevinquillen for getting a Drupal 11 ready version of Taxonomy Views Integrator out the door. I'll have a look at the changes to the code and compare it with my original submission, and learn where I can make improvements in my code. ATM I am dipping my toe in the water, as far as contributing back to the Drupal community.

GitLab CI integration has been added, so if you create issues or issue forks it will run that automatically for you, and some established test cases exist in code. Feel free to contribute openly, every bit helps. Thanks!

https://git.drupalcode.org/project/tvi/-/pipelines

Automatically closed - issue fixed for 2 weeks with no activity.