Thanks @damienmckenna and @kevinquillen for getting a Drupal 11 ready version of Taxonomy Views Integrator out the door. I'll have a look at the changes to the code and compare it with my original submission, and learn where I can make improvements in my code. ATM I am dipping my toe in the water, as far as contributing back to the Drupal community.
After much module testing, I now have a "working" TVI module on Drupal 11. The patch file is attached.
At this stage, the code has not gone through regression testing. If one of the module maintainers can do this at their earliest convenience, that would be great. (PS. I am a novice when it comes to Drupal module debugging / maintenance. So any pointers in this respect would be gladly appreciated.)
Thanks for the patch. However there are Symfony dependencies in TaxonomyViewsIntegratorManager (called ContainerAwareTrait & ContainerAwareInterface) that are no longer in Symfony 7.1 . ( See CallableResolver and ClassResolver no longer support ContainerAwareInterface → ). Can this be encompassed into the patch?
I've successfully been able to install Metatag v2 & Schema_Metatag v3 on my Drupal 10 site. I haven't fully tested it yet, but I think the blocker was the module yoast_seo, which had a dependency on metatag.
BTW, I discovered your Mediacurrent Youtube channel. Have been able to apply the 'lenient' plugin to my composer.json, in order to get some modules that were not well maintained, Drupal 11 ready, in order for the upgrade to proceed. I'll have to review those out-of-date modules in the not too distant future.
tomthorp → created an issue.
Just came across this same issue when migrating my Drupal site to Drupal 11.
The issue stems from upgrading Symfony from 6.4 to 7.1. In Symfony 6.4, ContainerAwareTrait became deprecated, with Symfony 7.1 being removed.
See Drupal change note that addresses this issue for the module maintainers. CallableResolver and ClassResolver no longer support ContainerAwareInterface →
The only JSON that's generated is via the Article Plugin in Schema_Metatag. Thus :
<script type="application/ld+json">{
"@context": "https://schema.org",
"@graph": [
{
"@type": "Article",
"headline": "PHP cURL error HTTP/2 stream 0 was not closed cleanly",
"name": "TomThorp.me",
"description": "When using PHP\u0027s cURL function, you may come across this error in your website log when the cURL function fails to retrieve information back. Here is the solution to this problem.",
"about": [
"PHP",
"cURL"
],
"image": {
"@type": "ImageObject",
"representativeOfPage": "True",
"url": "https://d11.tomthorp.me/sites/default/files/styles/summary_card_large/public/BlogImages/2000px-PHP-logo.svg__0_0.png?itok=FPDNjVBA",
"width": "600",
"height": "300"
},
"datePublished": "2024-01-24T16:59:37+1000",
"dateModified": "2024-01-24T17:13:03+1000",
"author": {
"@type": "Person",
"@id": "https://d11.tomthorp.me/about/biography",
"name": "Tom Thorp",
"url": "https://d11.tomthorp.me/about/biography"
},
"publisher": {
"@type": "Organization",
"@id": "https://d11.tomthorp.me/",
"name": "TomThorp.me",
"url": "https://d11.tomthorp.me/",
"logo": {
"@type": "ImageObject",
"url": "https://d11.tomthorp.me/sites/default/files/TomThorp_0.png"
}
},
"mainEntityOfPage": "https://d11.tomthorp.me/blog/php-curl-error-http2-stream-0-was-not-closed-cleanly"
}
]
}</script>
I don't believe I have used the MetatagHalNormalizer plugin. It is not listed in the list of plugins.
The list of plugins that are enabled on my site are :
Metatag Plugins
Facebook
Hreflang
Open Graph
Pinterest
Twitter Cards
Verification
Views
Schema_Metatag Plugins
Article
Metatag
Organization
Person
WebPage
WebSite
I did rebuild the caches, as outlined in my "steps to reproduce". ( using "drush updatedb", "drush cr" and "drush core:cron" ) .
tomthorp → created an issue.
Hi @sarwan,
I should of added when I did the upgrade, there were two other modules I had installed - metatag and schema_metatag. I'll outline from memory the events leading up to the error.
From what I can recall, metatag, schema_metatag and yoast_seo were all installed, enabled and all had an upgrade path to 10.1 prior to upgrading. Once I upgraded using composer to 10.1, in 'available updates' there were updates to metatag (v1.26 => v2.0) and schema_metatag (v2.5 => v3.0). Yoast_seo I believe was on v2.0alpha9 prior to the 10.1 upgrade.
When I tried updating metatag and schema_metatag modules to the new release, yoast_seo would not install unless it was on v1.8 (due to some conflict within composer.) Once Yoast_seo was downgraded to v1.8, that is when the problem arose.
Is there some code that needs to be introduced into the module's .install file to rectify this?
- Tom
tomthorp → created an issue.