- Issue created by @Anybody
- Status changed to Needs review
4 months ago 10:02am 22 August 2024 - Status changed to RTBC
4 months ago 10:06am 22 August 2024 - 🇮🇳India ankitv18
Next major pipeline is passing now ~~ Marking this one as RTBC
- 🇮🇳India ankitv18
Validate pipeline get fixed once this issue gets merged: https://www.drupal.org/project/auto_entitylabel/issues/3467643 🐛 Fix PHPCS & cspell Needs review
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Awesome work in here +1 @ankitv18 thanks! Can please use issue tags like [#issuenumber] for better readability in your comments. Thank you.
- 🇮🇳India ankitv18
Sure @dqd, actually @anybody already mentioned that in the related issue.
By the way, pipelines are clean now ~~ please proceed with the merge. - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Awesome work done in all these issues here @ankitv18! Very much appreciated. +1
PS: Related to the other merged issue, make sure the boxes for your credit are ticked. I did it know for you and hope it keeps added to the merge. I have conversation now on Slack what's going with the credits. We already had it on D.O. that it didn't work times before.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
@anktiv18: planned. That's why the proper title change and see comment #9
I need to clarify the issue with the credits otherwise you will complain missing credits again ;-)
So please stay calm.
- 🇮🇳India ankitv18
:D Actually when you merge the issue that will only merge over the codebase but I guess maintainer do manually check the checkboxes to whom they want to credit before updating the status to fixed.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
In this case here the check boxes keep being ticked. That was what I was after in one of my previous comments, because we had scenarios already on D.O. where these didn't kept being ticked. So that was not the issue. When I use the console to merge
git remote add auto_entitylabel-3469652 git@git.drupal.org:issue/auto_entitylabel-3469652.git git fetch auto_entitylabel-3469652
... and push from there it usually works. Or when I use the traditional way of git clone and push. It only does not work when merging via Gitlab UI. Which I didn't know because I usually work on console only. Yesterday I was on the road while merging, so I used the UI.
- Status changed to Fixed
4 months ago 11:09am 25 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.