- Issue created by @Tyapchyc
- Issue was unassigned.
- Status changed to Needs review
3 months ago 10:41am 21 August 2024 - πΊπ¦Ukraine Tyapchyc
Hello @liam-morland, @alan-d, @heddn, @nkoporec, @rconstantine, @webflo
Could you please review this?
Thank you
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
It looks reasonable. There shouldn't be two spaces before
coreVersion
in its declaration. That method can probably be static. - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Another approach would be to make a 2.0.x branch for Drupal 10.3 and later, including Drupal 11. Then there is no need for any version checks. Depending on the code, it can be difficult to make it compatible with versions earlier than 10.3 and with 11.