- Issue created by @dpi
- 🇦🇺Australia dpi Perth, Australia
We can also fix up https://drupal.org/node/3395436 for autoconfiguration, and remove use of ContainerInjectionInterface.
- 🇦🇺Australia dpi Perth, Australia
This also moves use of config out of constructor. Its by convention a config isnt stored from the constructor, its accessed from configfactory on demand as its state can change during the lifecycle of a request.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 10:40am 19 August 2024 - Status changed to Needs work
5 months ago 4:24pm 22 August 2024 - Status changed to Needs review
5 months ago 7:05am 23 August 2024 - 🇦🇺Australia dpi Perth, Australia
Feedback and questions for maintainers. Nothing actionable by non-maintainers.
- First commit to issue fork.
-
marcoscano →
committed e5537b94 on 8.x-2.x authored by
dpi →
Issue #3468898 by dpi, claudiu.cristea, marcoscano: Modernize services:...
-
marcoscano →
committed e5537b94 on 8.x-2.x authored by
dpi →
- Status changed to Fixed
5 months ago 10:29am 24 August 2024 - 🇪🇸Spain marcoscano Barcelona, Spain
Thanks for helping modernize the module's codebase. I don't feel strongly about the readonly property and/or docblocks, so I'd say let's get this in and iterate over in 📌 Fix the issues reported by phpcs Needs review , where we can fix these and other CS violations that have bubbled up lately.
Thanks again!
Automatically closed - issue fixed for 2 weeks with no activity.