Alias services for autowiring

Created on 18 June 2024, over 1 year ago

Problem/Motivation

As drupal supports autowire add aliases to services.

Core CR: https://www.drupal.org/node/3218156

Proposed resolution

Create service aliases for public services:
- flag
- flag.link_builder

Remaining tasks

- Create aliases

User interface changes

No changes

API changes

Should not be any

Data model changes

No changes

Feature request
Status

Active

Version

4.0

Component

Flag core

Created by

🇸🇮Slovenia kbrodej

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kbrodej
  • Merge request !66Issue #3455365: Alias services for autowiring → (Merged) created by kbrodej
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    over 1 year ago
    Total: 223s
    #201881
  • Issue was unassigned.
  • Status changed to Needs work over 1 year ago
  • 🇧🇾Belarus ivnish

    MR needs rebase

  • First commit to issue fork.
  • 🇺🇸United States tr Cascadia

    Rebased. But why are only two of the services aliased?

  • Pipeline finished with Success
    over 1 year ago
    Total: 138s
    #315598
  • 🇺🇸United States tr Cascadia

    Also, why just add the aliases? Why not change the service classes to use the autowiring? That is where the real benefit comes in, and that also serves as a tests to demonstrate that the change to both flag.services.yml and the service implementation classes are correct.

  • Pipeline finished with Failed
    25 days ago
    Total: 208s
    #702915
  • Pipeline finished with Failed
    25 days ago
    Total: 196s
    #702917
  • Pipeline finished with Failed
    25 days ago
    Total: 186s
    #702931
  • Pipeline finished with Success
    24 days ago
    Total: 103519s
    #702933
Production build 0.71.5 2024