Contrib.social

Create and utilise autowiring aliases for OpenID Connect

Open on Drupal.org →
Created on 19 July 2024, 6 months ago

Problem/Motivation

All currently supported versions of Drupal core support autowiring aliases.

Lets create aliases and utilise core's aliases to improve DX of projects relying on openid_connect, and clean up openid_connect.services.yml file.

Proposed resolution

Use core aliases where possible.
Add manual wiring for externalauth

Remaining tasks

Implement.
Tests not required.
Increase minimum supported version of core to the minimum current supported version of core.

User interface changes

None

API changes

Added service aliases.

Data model changes

None

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dpi
  • Merge request !118Draft: Resolve #3462532 "Autowiring" → (Open) created by dpi
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇦🇺Australia dpi Perth, Australia
  • Pipeline finished with Failed
    6 months ago
    Total: 196s
    #228483
  • Pipeline finished with Success
    6 months ago
    Total: 139s
    #228526
  • First commit to issue fork.
  • Pipeline finished with Failed
    6 days ago
    Total: 330s
    #390408
  • Comment 5 days ago →
    🇺🇸United States dcam

    I'm not sure what the problem is with the one test failure. If you remove this line:

    Drupal\openid_connect\OpenIDConnect: '@openid_connect.openid_connect'

    ...then the test passes. But if I understand the documentation correctly, then that line is important for downstream modules to use autowiring. So it can't just be deleted.

    I've tried to identify what the problem might be, but haven't had success. The error occurs while the container is being built.

  • Comment 5 days ago →
    🇺🇸United States dcam
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024