Contrib.social

ComponentPluginManager should detect if an extension provides two different components that resolve to the same plugin ID

Open on Drupal.org →
Created on 19 August 2024, 4 months ago

Problem/Motivation

  1. I write a module.
  2. I add components/image.component.yml
  3. Months later, I add many components, and I add component/simple/image.component.yml
  4. On some environments, this crashes, on others it does not.

Steps to reproduce

See above.

Proposed resolution

Detect the duplicate plugin ID within an extension, and throw a helpful exception.

Remaining tasks

  • Explicit test coverage. (I suggest following the pattern that \Drupal\Tests\ckeditor5\Kernel\CKEditor5PluginManagerTest::testInvalidPluginDefinitions() established.)
  • Fix.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

📌 Task
Status

Active

Version

11.0 🔥

Component
single-directory components  →

Last updated about 12 hours ago

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024