- Issue created by @clayfreeman
- Issue was unassigned.
- Status changed to Needs review
4 months ago 10:39pm 16 August 2024 - 🇺🇸United States clayfreeman Paragould, AR
Ready for initial round of feedback.
Hi,
I've reviewed the MR !9233 on Drupal 11.x.Changes Looks good to me. [view:title] token values are render properly.
- Status changed to Needs work
4 months ago 2:19pm 5 September 2024 - 🇺🇸United States smustgrave
Left some comments on the MR.
If it turns out all those changes are needed then I'm definitely nervous this could break existing sites since we had to update tests to pass.
- Status changed to Needs review
4 months ago 3:18pm 5 September 2024 - 🇺🇸United States clayfreeman Paragould, AR
I left some replies. We need to decide first and foremost whether we want to allow HTML tags in the title. If not, then these changes you marked as out of scope can be reverted.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States clayfreeman Paragould, AR
I'm not sure this bot is accurate; I'm not seeing any specific CSpell errors, and none were highlighted in CI anyway.
- Status changed to Needs work
about 1 month ago 2:28pm 21 November 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.