- Issue created by @geekygnr
- 🇳🇿New Zealand quietone
Changes are made to the 11.x, the main development branch, and then backported according to our policies.
- 🇨🇦Canada geekygnr Waterloo
Sending this up for review since I got all the tests to pass.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Will also need usability review but the summary should be complete to help that team, UI changes require before/after screenshots for example
- 🇨🇦Canada geekygnr Waterloo
Merged 11.x back into the MR and added some fixes.
Thanks for the feedback.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇮🇳India shalini_jha
Fixed issue reported by bot but seems some phpstan failure.
- Status changed to Needs review
5 months ago 11:05am 3 December 2024 - 🇮🇳India shalini_jha
I have reviewed the recent changes and found that the removal of the messenger service is incorrect because it is used in addStatus(). This caused the test to fail. Additionally, after updating the type hint, the pipeline failed. To resolve this, I first fixed the PHPStan issues, regenerated the baseline, and addressed the test coverage issues related to addStatus(). The pipeline is now fixed. As mentioned in #12, I am moving the project back to "Needs Review."
- 🇮🇳India sagarmohite0031
Hello,
Tested and verified ob drupal 11.
MR applied successfully.
Attaching before and after screenshots. The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs work
about 2 months ago 10:52am 6 March 2025 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India shalini_jha
Rebased and fixed conflicts also regenerated the based line for fixing the pipeline failure. Moving this back to NR.Kindly review