Back-end route to allow logging from the UI

📌 Improve client side error handling Fixed is in — the next step is ✨ [PP-1] Log client-side errors Postponed , which this is a blocker for.

Thanks, @omkar-pd, looking good! This still needs a functional test 😊

Created my first tests.😃 Probably will need some changes.

Addressed test coverage issue , test passed on local however left there one comment on MR for test coverage need suggestion here , fixed undefined variable errors for newly added route, rebased the MR & resolved conflicts.

Please review, moving NR

#8: Congrats! 😄

This is 99% ready! 👏 The test looks great 😊 — impressive for your very first test! (And thanks @pooja_sharma for putting those nice finishing touches on it!)

Thanks @wim-leers for recognizing efforts happy to contribute , got your concerns regarding test coverage feedback after removing standard profile code, test resource usage goes from Time: 00:16.673, Memory: 4.00 MB to Time: 00:05.687, Memory: 4.00 MB which eliminates the half of test execution time (much faster).

I m here for contributing for test coverage as per request @omkar-pd, initially much of the work done by him so letting him to cover up pending feedback.

Thank you @wim-leers and @pooja_sharma.

I've addressed the feedback given. Moving this to NR.

Bump

Assigning to @Wim Leers for review

This should wait for 📌 Also validate request bodies against the OpenAPI spec Downport to land — it makes openapi.yml more maintainable.

(I expect to land in the next hour or so though 👍)

📌 Also validate request bodies against the OpenAPI spec Downport is in, rebasing…

LGTM!

But since I requested @traviscarden to become the CODEOWNER for /openapi.yml at #3466555-21: Also validate request bodies against the OpenAPI spec → .3, I'd like him to do the final review 😊

Nice contribution! I've requested some changes on the MR.

@wim-leers, @traviscarden

Need suggestions for this.
https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...

Will review/merge in upstream to get this back on track, because 🐛 OpenAPI validation errors must be provided as a JSON response RTBC has landed and this blocks the subsequent steps 🤓

To answer #23:

There was 1 error:
1) Drupal\Tests\experience_builder\Functional\LogControllerTest::testLogController
Exception: Warning: Undefined array key "invalid_log_level"
Drupal\Core\Logger\LoggerChannel->log()() (Line: 123)
/builds/issue/experience_builder-3467843/web/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55

shows that there's a bug in the controller logic:

    if (empty($error_level)) {
      return new JsonResponse(['error' => 'Log level is required'], 400);
    }

    // Log the error.
    $this->logger->log($error_level, $error_message);

👆 That doesn't verify the log level is valid, only that one is specified.

@larowlan's https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... still needs to be addressed.

Almost there! 😄

Still needs the tests that @larowlan suggested.

Final review pass, fixed my own nits. Looked great!

I actually don't quite like that this is now a unit test instead of a functional test. Because it doesn't prove the route actually works, only that the controller works.

But … ✨ [PP-1] Log client-side errors Postponed will have to add an end-to-end test, and that's even better.

So: RTBC! This now only needs MR approval from @traviscarden, so assigning to him.

Nice! I prettified openapi.yml and approved it.

Yay! Merged and unpostponing ✨ [PP-1] Log client-side errors Postponed 👍

🎉🎉

Automatically closed - issue fixed for 2 weeks with no activity.