- Issue created by @quietone
- Status changed to Needs review
3 months ago 8:33am 11 August 2024 - Status changed to RTBC
3 months ago 3:02pm 11 August 2024 - πΊπΈUnited States smustgrave
Seems straight forward. Was curious where the subtractions came from and see
core/modules/views/src/Plugin/views/filter/FilterPluginBase.php where the @var value was above the description. So that seems fine
Rest LGTM
- Status changed to Needs work
3 months ago 11:56pm 16 August 2024 - π¬π§United Kingdom catch
phpcs isn't happy locally:
FILE: ...ests/Drupal/FunctionalTests/Installer/InstallerConfigDirectoryTestBase.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 21 | ERROR | [x] Expected "string|null|bool" but found "string|NULL|bool" for | | @var tag in member variable comment 28 | ERROR | [ ] The @var tag must be the first tag in a member variable | | comment
The @var tag must be the first tag in a member variable
| | commentThis one is because of the @todo above I think.
- Status changed to Needs review
3 months ago 1:01am 17 August 2024 - π³πΏNew Zealand quietone
I removed the @todo because the missing summary line will be discovered when enabling "Drupal.Commenting.VariableComment.Missing" as part of π± [meta] Fix 'Drupal.Commenting.VariableComment' coding standard Active . And then change NULL to null.
- π¦πΊAustralia mstrelan
Re-titling as this appears to be addressing properties rather than params.
- Status changed to RTBC
3 months ago 2:35pm 17 August 2024 - Status changed to Needs work
3 months ago 7:31am 30 August 2024 - Status changed to Needs review
3 months ago 7:47am 30 August 2024 - π³πΏNew Zealand quietone
Rebase with one conflict in \Drupal\FunctionalTests\Update\UpdatePathTestBase
- π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.0.x and 10.4.x. Doesn't cherry-pick cleanly to 10.3.x but I think that's OK.
- Status changed to Fixed
3 months ago 8:02am 30 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.