- Issue created by @quietone
- Status changed to Needs review
5 months ago 6:52am 10 August 2024 - Status changed to RTBC
5 months ago 2:53pm 11 August 2024 - πΊπΈUnited States smustgrave
Seems straight forward. The addition to subtraction is equal and spot checked a few dozen.
- π¬π§United Kingdom longwave UK
Wondering if this should just be @inheritdoc in most cases except where we add additional information?
- πΊπΈUnited States smustgrave
Is true most could probably use that and the @var part
- Status changed to Needs review
5 months ago 12:23pm 17 August 2024 - π¬π§United Kingdom catch
Moving back to needs review, I think I agree with #5 but if we're going to change to that, we might as well do that here?
- π³πΏNew Zealand quietone
Used the following to make the conversion to inheritdoc.
grep -r "* Modules to install." core | awk -F: '{print $1}' | xargs sed -z -i 's#Modules to install.\n \*\n \* @var array#{@inheritdoc}#' grep -r "* Modules to install." core | awk -F: '{print $1}' | xargs sed -z -i 's#Modules to install.\n \*\n \* @var string\[\]#{@inheritdoc}#'
Then found remaining one with a simple search and did them by hand.
There is one remaining instance of 'modules to enable' but since that is not in a comment let's do that in a separate issue.
$ git grep -i 'modules to enable' core/lib/Drupal/Core/Installer/Exception/NoProfilesException.php: $message = $this->t('We were unable to find any installation profiles. Installation profiles tell us what modules to enable and what schema to install in the database. A profile is necessary to continue with the installation process.');
- Status changed to RTBC
5 months ago 1:23am 18 August 2024 - First commit to issue fork.
- π«π·France nod_ Lille
There is one "module to enable" left in
EntityDefinitionUpdateProviderTest
without additional information, it was added last week so makes sense it got missed.RTBC +1
-
longwave β
committed 8c274c9f on 10.3.x
Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change...
-
longwave β
committed 8c274c9f on 10.3.x
-
longwave β
committed 6f000d4b on 10.4.x
Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change...
-
longwave β
committed 6f000d4b on 10.4.x
-
longwave β
committed 4d8f5eb2 on 11.0.x
Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change...
-
longwave β
committed 4d8f5eb2 on 11.0.x
-
longwave β
committed c28a1fb6 on 11.x
Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change...
-
longwave β
committed c28a1fb6 on 11.x
- Status changed to Fixed
5 months ago 5:31pm 27 August 2024 - π¬π§United Kingdom longwave UK
Decided to backport this one to all active branches as a docs-only fix and to keep things in sync given that it touches a lot of files, otherwise it will make future cherry-picks more tricky in some cases.
Automatically closed - issue fixed for 2 weeks with no activity.