Update JavaScript dependencies for Drupal 11.0.0

-

Bah, we can't update stylelint because of stylelint-formatter-gitlab: https://gitlab.com/leon0399/stylelint-formatter-gitlab/-/issues/3

@longwave in #3439522-16: Update JavaScript dependencies for Drupal 10.3/11.0 →

I think we need an issue to decide if stylelint-formatter-gitlab should be considered abandoned and look for alternatives.

I found a JS alternative here: #3460114-7: Update JavaScript dependencies for Drupal 11.0-rc → , but there should/might be easier ways.

Anyway, doesn't seem right we don't update a dependency "simply" because the reporting can't handle the update.

Great stuff...

Seems that floating-ui was never updated in our core/assets/vendor when using yarn vendor-update, because it has no entry in core/scripts/js/vendor-update.js const ASSET_LIST...

Should have fixed the above, but me thinks we need another follow-up to create a test that makes sure all our JS-assets are actually updated when doing a yarn vendor-update.

Although prettier was updated, a $ yarn prettier shows no changes.

fixed up the floating ui declaration, no need to mess with the processing :)

Thanks @_nod

Since we're using a new version of cspell, also did a $ yarn spellcheck:make-dict.

I imagine this will probably conflict with 📌 Update Nightwatch to 3.x Fixed . I'm not sure what to do about that issue, but it should take precedence since a major version upgrade of Nightwatch is a significant thing for core maintenance (and will likely slip to D12 otherwise).

Discussed with @longwave and we might do the Nightwatch 3 update in 11.1, which would mean this could still go in today before 11.0.0 (should it be RTBCed).

floating ui is used by navigation and the update didn't break anything.
underscore just updated the license data, no code changes.
build/lint scripts didn't change

I checked the following to ensure there were no diffs from the MR:

cd core
yarn install
yarn spellcheck:make-dict
yarn run build
yarn prettier

...And of course CSS and JS linting happen in my pre-commit hook.

When I cherry-picked it to 11.0.x and repeated the above, there was one additional misspelling:

[ayrton:core | Thu 16:27:41] $ git diff
diff --git a/core/misc/cspell/dictionary.txt b/core/misc/cspell/dictionary.txt
index 79e14b2a06..232320fd08 100644
--- a/core/misc/cspell/dictionary.txt
+++ b/core/misc/cspell/dictionary.txt
@@ -710,6 +710,7 @@ untabbable
 upcasted
 upcasting
 updateprogress
+uploaders
 uploadprogress
 upscaling
 urandom

This is found in:
core/modules/update/src/Form/UpdateManagerInstall.php: $test_authorize = \Drupal::state()->get('test_uploaders_via_prompt', FALSE);
...which was deleted in 📌 Remove adding an extension via a URL Fixed , so I amended the 11.0.x cherry-pick to add it back to the dictionary. Probably a problem with the previous commit rather than new versions of dependencies here, but I amended the commit anyway so that the linting tests don't fail on 11.0.x:

[ayrton:maintainer | Thu 16:36:12] $ cd core
[ayrton:core | Thu 16:36:15] $ yarn spellcheck:make-dict
[ayrton:core | Thu 16:36:30] $ cd ..
[ayrton:maintainer | Thu 16:38:00] $ git diff
diff --git a/core/misc/cspell/dictionary.txt b/core/misc/cspell/dictionary.txt
index 79e14b2a06..232320fd08 100644
--- a/core/misc/cspell/dictionary.txt
+++ b/core/misc/cspell/dictionary.txt
@@ -710,6 +710,7 @@ untabbable
 upcasted
 upcasting
 updateprogress
+uploaders
 uploadprogress
 upscaling
 urandom
[ayrton:maintainer | Thu 16:38:01] $ git add core/misc/cspell/dictionary.txt
[ayrton:maintainer | Thu 16:38:30] $ git commit --amend -m 'Issue #3465166 by Spokje, nod_: Update JavaScript dependencies for Drupal 11.0.0'

Then confirmed re-running the dictionary build did not result in additional changes.

Thanks!

Do we still need that followup about stylelint-formatter-gitlab?

xjm → closed merge request !9020

Do we still need that followup about stylelint-formatter-gitlab?

Opened 📌 stylelint-formatter-gitlab prevents updating stylelint Active

Automatically closed - issue fixed for 2 weeks with no activity.