- Issue created by @quietone
- Status changed to Needs review
11 months ago 6:01am 30 July 2024 - Status changed to RTBC
11 months ago 2:07pm 30 July 2024 - πΊπΈUnited States smustgrave
Reviewed the changes and the replacements seem fine. Nothing that would be breaking least
- Status changed to Needs work
11 months ago 5:12pm 22 August 2024 - π¬π§United Kingdom longwave UK
Added some nits where the trait is not required, and there is a case where the trait is added to a test case itself which is not correct - we shouldn't be using
t()
at all in test code. - Status changed to Needs review
11 months ago 1:18am 23 August 2024 - Status changed to RTBC
11 months ago 12:14pm 23 August 2024 - π¬π§United Kingdom longwave UK
Nightwatch tests seem to be consistently failing here - I reran the job and it failed again - maybe we broke something?
- Status changed to Needs work
8 months ago 10:22am 21 November 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
-
larowlan β
committed 95579a70 on 11.x
Issue #3464591 by quietone, longwave: Fix DrupalPractice.Objects....
-
larowlan β
committed 95579a70 on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x - thanks!
Automatically closed - issue fixed for 2 weeks with no activity.