- Issue created by @joehuggans
- 🇩🇪Germany Anybody Porta Westfalica
+1 for this, would be really helpful! :)
- Merge request !37Issue:3464143-provide-option-to: Provided-option-to-infinite-loop → (Open) created by dhruv.mittal
- 🇩🇪Germany Anybody Porta Westfalica
Grea work @dhruv.mittal! LGTM.
Best would be to have tests for the various functionalities of this module to ensure it works as expected. That should be a separate issue though.
Until that, we need confirmation from users that this works as expected. Would you like to open a new issue for tests to speed things up? @anybody thanks for appreciating. But currently I'm learning about PHPUnit tests only and so it will be difficult to implement it in the MR and it would be good if a new issue could be opened for it?
- 🇬🇧United Kingdom joehuggans Harrogate, UK
That sounds good both, I can help out with the tests. I was going to work on this myself as my original message stated but then I noticed a lot of work already gone into the dev version of the module so didn't want to step on your toes.
If a new ticket can be created I will help out the best I can.
- 🇩🇪Germany Anybody Porta Westfalica
@Joe Huggans yes, testing this first would make sense. From my side it's not a blocker here, if enough people manually ensured that it works.
- 🇬🇧United Kingdom joehuggans Harrogate, UK
Tested this and it works well. Nice one!
- Status changed to RTBC
3 days ago 7:15am 21 November 2024 - 🇮🇳India lavanyatalwar
I have reviewed it, and the issue seems to have been resolved. I am attaching a screen recording for reference. Moving it to RTBC.