Add aria-autocomplete=none alongside autocomplete=off

Created on 20 July 2024, about 2 months ago

Updated 29 July 2024, about 1 month ago

Problem/Motivation

When editing a user account that isn't the current user, the MS Edge browser no longer adheres to the autocomplete="off" attribute added on forms, resulting in the browser autofilling.

Steps to reproduce

Have multiple user accounts on the site, "User A" and "User B".
Give User A the "administer users" permissions.
In MS Edge, log into the site as User A.
Open User B's edit form.

What should happen:
The username field is not autofilled with User A's username i.e. it says "User B".

What happens:
The username field is autofilled with "User A".

Proposed resolution

Update Form API so that any time it adds the "autocomplete" attribute and sets it to "off" it also adds the "aria-autocomplete" attribute and sets it to "none".

Remaining tasks

Work out the necessary changes.
Add test coverage.

User interface changes

Loading the user edit form in MS Edge does not autofill the current user's username into the username field.

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Form →

Last updated less than a minute ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇺🇸United States DamienMcKenna NH, USA

Live updates comments and jobs are added and updated live.

Merge Requests

!8858Add aria-autocomplete=none alongside autocomplete=off
Open
🇺🇸United States DamienMcKenna
updated about 2 months ago

Comments & Activities

Issue created by @DamienMcKenna
Status changed to Needs review about 2 months ago3:37pm 20 July 2024
Comment about 2 months ago →
🇺🇸United States DamienMcKenna NH, USA
Proposed changes, in patch format.
Merge request !8858Add aria-attribute=none when adding autocomplete=off. → (Open) created by DamienMcKenna
Pipeline finished with Failed
about 2 months ago
Total: 575s
#229794
Comment about 2 months ago →
🇳🇿New Zealand quietone New Zealand
Comment about 2 months ago →
🇺🇸United States DamienMcKenna NH, USA
I was informed that the root problem was in fact a browser plugin rather than the browser itself. As such, we might consider this a feature request rather than a bug report?
Status changed to Needs work about 1 month ago2:51pm 29 July 2024
Comment about 1 month ago →
🇺🇸United States smustgrave
Reran nightwatch and still fails so appears to be legit to the issue

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024