- Issue created by @ericgsmith
- 🇳🇿New Zealand ericgsmith
Adding 💬 Webform issue during enabling Fixed as a related issue as it seems the change is catching other people out
- 🇬🇧United Kingdom catch
I think if these are useful independently without acftions UI module, then it makes sense for them to be in core - or at least I don't think moving to actions UI was the right approach in that case, since it shouldn't become a dependency for VBO or webform.
Had a quick check to see if the commit from 📌 Move some Action plugins to Action module Needs review would revert against 10.3.x and 10.4.x and it doesn't, so will require a bit of work. We can probably skip the migration/upgrade test changes and just bring the actions and their own test coverage back in.
- Merge request !8865Issue #3462523: Undo deprecation of UnpublishByKeyword and AssignOwnerNode action plugins → (Open) created by ericgsmith
- Status changed to Needs review
4 months ago 10:29pm 21 July 2024 - 🇳🇿New Zealand ericgsmith
Opened https://git.drupalcode.org/project/drupal/-/merge_requests/8865 against 11.x and https://git.drupalcode.org/project/drupal/-/merge_requests/8866 against 10.4.x
I note that there was no existing test for
AssignOwnerNode
- do we need a test for this as part of this issue or a follow up (given we are just moving them back)? - Status changed to Needs work
4 months ago 6:06pm 25 July 2024 - 🇺🇸United States smustgrave
Since the previous CR is published can we get a new one if we are un-deprecating these.
- 🇵🇱Poland Graber
Subscribing, just noticed this opened on VBO: 💬 Can we use this for changing node authors en-masse? Active , also no idea why would anyone move a node-specific action from node module?
- 🇵🇱Poland Graber
Just found out Actions UI is deprecated and will be removed from core.. Maybe we should move those actions to VBO instead since they will be removed completely anyway?
- 🇳🇿New Zealand ericgsmith
Thank you for linking that issue @graber
Just found out Actions UI is deprecated and will be removed from core.. Maybe we should move those actions to VBO instead since they will be removed completely anyway?
This is what I would debate - the Actions UI module does not provide any functionality needed for these plugins to be useful - the UI module (which is not often installed) was never required for these plugins to work.
There are several other plugins that still have a UI via
buildConfigurationForm
that remain in core in Drupal 11. I don't see how there was never a need to remove these plugins based on action UI being removed - or what makes them so different from other plugins retained.I also do not think views bulk operation is the appropriate place for these plugins - as other modules that use the action plugins such as ECA also may have a use for these plugins and their users may not want to introduce a dependency on VBO (or Actions UI) to keep them.
I added a CR which is essentially the reverse of 📌 Undo deprecation of UnpublishByKeyword and AssignOwnerNode action plugins Active
I've also had another read of 🌱 [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11 Fixed which I think has relevant information - a lot of the discussion is that there would just be the action ui module removed and no removal of actual plugins.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.