- Issue created by @lauriii
- Assigned to jessebaker
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
This blocks #3462314, see #3462314-2: [PP-1] Improve primary menu bar - remove need for "overlayForHover" โ .
Also, ๐ End-to-end test that tests both the client (UI) and server Active just landed, so I think it's time we start requiring basic test coverage for each new piece in the UI?
- Assigned to hooroomoo
- ๐ฌ๐งUnited Kingdom jessebaker
Assigning to @hooroomoo as they have been working on the left hand menu so far.
Sorry hooroomoo, it looks like there are some iterations/updates required to the menu work you did now that the designs have progressed further.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
(To elaborate on #4: @hooroomoo landed that in โจ Create UI scaffolding for the primary panel (left sidebar) Needs work .)
- First commit to issue fork.
- Issue was unassigned.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Unassigning @hooroomoo, because AFAICT they're not actively working on this?
- Assigned to hooroomoo
- ๐บ๐ธUnited States hooroomoo
Picking this back up now that ๐ Implement add button for top level item (section) Fixed is in
Removing blocker tag bc this issue will be removing the overlayForHover since tooltip is no longer part of the design.
- ๐บ๐ธUnited States hooroomoo
hooroomoo โ changed the visibility of the branch 3462413-menu to hidden.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
will be removing the overlayForHover since tooltip is no longer part of the design
Could you link to the source for that? ๐
- ๐บ๐ธUnited States hooroomoo
#13 I should make a correction
"will be removing the overlayForHover since the first level menu in the sidebar with the icons is no longer part of the design as seen in the screenshots in the IS and the Figma."
The first level menu in the left sidebar has the overlayForHover attribute which will be removed in this issue.
- Status changed to Needs review
25 days ago 1:08am 14 August 2024 - ๐บ๐ธUnited States hooroomoo
The tests still need to be fixed but the implementation can be reviewed
- ๐บ๐ธUnited States hooroomoo
Removing the needs tests tag. Tests for the Layers (tree) should be done as part of ๐ Improve the page hierarchy display Active .
The MR has a solid foundation for ๐ Improve the page hierarchy display Active but still needs styling/dragging tweaking when with nested components.
- Issue was unassigned.
-
hooroomoo โ
committed f7b866f7 on 0.x
Issue #3462413 by hooroomoo, jessebaker: Implement the updated insert...
-
hooroomoo โ
committed f7b866f7 on 0.x
- Status changed to Fixed
23 days ago 4:00pm 15 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.