Drupal 11 support

Created on 18 July 2024, 12 months ago
Updated 7 October 2024, 9 months ago
  • Add CI
  • Remove phpstan errors
Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇦🇺Australia VladimirAus Brisbane, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @VladimirAus
  • Merge request !14Drupal 11 support → (Open) created by VladimirAus
  • Pipeline finished with Failed
    12 months ago
    Total: 272s
    #227373
  • First commit to issue fork.
  • Pipeline finished with Failed
    9 months ago
    #303218
  • 🇫🇷France prudloff Lille

    I removed Drupal 9/10 in core_version_requirement because I removed everything related to the editor.image_dialog route (which was removed in Drupal 11), but we might want to publish a transition release compatible with both Drupal 10 and Drupal 11 first.

  • 🇦🇺Australia VladimirAus Brisbane, Australia
  • Pipeline finished with Failed
    4 months ago
    Total: 209s
    #446960
  • Status changed to Needs work 4 months ago
  • 🇫🇷France prudloff Lille

    phpstan is complaining that it does not find ckeditor (4) classes.
    I think the solution would be to add drupal/ckeditor to dev dependencies in composer.json.
    But do we want to keep supporting CKE 4? The ckeditor contrib module is abandoned.

  • 🇺🇸United States laura.gates

    Just as a FYI, the patch applies successfully but errors out when running drush updb:

    [error] (Currently using Incompatible module The following module is installed, but it is incompatible with Drupal 10.4.6:
    * Inline Styled Images

  • 🇺🇸United States redeight

    Looks like the core_version_requirement is being set from
    core_version_requirement: ^9.3 || ^10
    to
    core_version_requirement: ^11

    Which explains the error seen in #7. Until D10 is completely unsupported it would make sense to keep 10 as a supported version. Can we get it set as
    core_version_requirement: ^10.1 || ^11

  • 🇫🇷France prudloff Lille

    The EditorImageDialog class and the editor.image_dialog route have been removed from Drupal 11, which is why I removed code related to this.
    We can restore it but we will have to allow the "upgrade status" job to fail then because it will complain that EditorImageDialog is deprecated.

  • Pipeline finished with Failed
    about 2 months ago
    #501128
  • Pipeline finished with Success
    about 2 months ago
    Total: 200s
    #501132
  • 🇫🇷France prudloff Lille

    phpstan needs drupal/ckeditor to analyze its classes but this module can't be installed on Drupal 11 (and the CI uses Drupal 11).
    I see no other solution than to allow the phpstan job to fail for now, we can then open a followup later about removing CKE 4 support.

  • 🇺🇸United States laura.gates

    @redeight. - setting the core version requirement to core_version_requirement: ^10.4 || ^11 likely makes the most sense given that 10.3 hits end of life next month.

  • 🇦🇺Australia jannakha Brisbane!

    CI is failing, for D11 it should be all green
    +1 for #11 comment

  • 🇫🇷France prudloff Lille

    @jannakha the MR introduces new jobs that weren't checked before. IMHO fixing spelling issues and phpstan bad practices is out of scope for this issue and could be fixed in a followup issue.

    Also see #10, I don't think we can make the phpstan job green while keeping support for CKE 4.
    We could remove CKE 4 support in this MR, but I feel it would be better to remove it in a separate followup issue.

  • 🇺🇸United States laura.gates

    @VladimirAus

    The plain diff and downloading the patch from github both don't apply. I'm using Drupal 10.4.6. Something else might be going on with this fork. If I get some downtime in the next couple of days, I'll try to isolate what's flagged in upgrade status:

    modules/contrib/inline_responsive_images/src/Form/ResponsiveEditorImageDialog.php
    modules/contrib/inline_responsive_images/inline_responsive_images.info.yml
    modules/contrib/inline_responsive_images/composer.json

    into its own fork

  • 🇮🇳India Vishal Choudhary Dharmshala

    vishal choudhary changed the visibility of the branch 3462224-drupal-11-support to hidden.

  • 🇺🇸United States laura.gates

    laura.gates changed the visibility of the branch 3462224-D11-compatiblity-from-3.0.1 to hidden.

  • 🇺🇸United States laura.gates

    laura.gates changed the visibility of the branch 3462224-D11-compatiblity-from-3.0.1 to active.

  • 🇺🇸United States laura.gates

    The diff for targeting only the three issues flagged by upgrade status applies for me. I'm uploading it here as a patch. This should hold folks over while the issue with the 4.x branch is figured out.

  • 🇺🇸United States laura.gates

    laura.gates changed the visibility of the branch 3462224-drupal-11-support to active.

  • 🇮🇳India Vishal Choudhary Dharmshala

    vishal choudhary changed the visibility of the branch 3462224-drupal-11-support to hidden.

  • 🇦🇺Australia VladimirAus Brisbane, Australia

    vladimiraus changed the visibility of the branch 3462224-automated-d11-support to hidden.

  • 🇦🇺Australia VladimirAus Brisbane, Australia

    vladimiraus changed the visibility of the branch 3462224-drupal-11-support to active.

  • 🇦🇺Australia VladimirAus Brisbane, Australia

    CI is green and all CKEditor 4 references were removed.
    Ready for review.

Production build 0.71.5 2024