- Issue created by @joachim
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Prem Suthar → made their first commit to this issue’s fork.
- Merge request !89213462098-hooklocaltasksalter-and-hookmenulocaltasksalter : Add th @see Link... → (Closed) created by prem suthar
- Status changed to Needs review
9 months ago 7:49am 25 July 2024 - 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@joachim I have added the Changes As per my Understanding , Please Review It and give The suggestions .
- Status changed to Needs work
9 months ago 8:27am 25 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
9 months ago 9:55am 25 July 2024 - 🇬🇧United Kingdom joachim
Looks good, not sure why the bot is unhappy as the MR pipeline has passed.
- Status changed to Needs work
9 months ago 4:19am 26 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
9 months ago 6:54am 26 July 2024 - 🇳🇿New Zealand quietone
Failing commit code check locally only. PHPStan doesn't like it when there is only one file and it *.api.php.
- Status changed to RTBC
9 months ago 11:47am 26 July 2024 - 🇬🇧United Kingdom joachim
> PHPStan doesn't like it when there is only one file and it *.api.php.
Urgh! is there an issue for that problem?
- 🇫🇷France nod_ Lille
Committed and pushed e8cafee5ae to 11.x and 58f4b99d0f to 11.0.x and 1009866a33 to 10.4.x and a3075fda43 to 10.3.x. Thanks!
- Status changed to Fixed
9 months ago 12:48pm 26 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.