- Issue created by @catch
- Merge request !8795Issue #3461860: make route lookup caching more efficient. β (Closed) created by catch
- π¬π§United Kingdom catch
MR does two things:
1. When generating the cache ID, runs the same logic as the decode inbound path processor. That processor should be merged into the router, all it does by trying to decouple it is create inconsistencies. See π After updating Drupal from version 10.2.7 to version 10.3.0, a 404 error occurred! Needs review for more.
2. When no routes are found, instead of caching a serialized empty route collection, caches FALSE instead. Given 404s are unbounded, while this is a relatively small saving, it's potentially multiplied by a lot of cache items.
- Status changed to Needs review
about 2 months ago 4:58pm 16 July 2024 - Status changed to Active
about 2 months ago 1:22am 17 July 2024 - π¬π§United Kingdom catch
Moved the URL normalization stuff into π After updating Drupal from version 10.2.7 to version 10.3.0, a 404 error occurred! Needs review .
- Status changed to Needs review
about 2 months ago 4:42am 17 July 2024 - Status changed to RTBC
about 2 months ago 6:22pm 20 July 2024 - πΊπΈUnited States smustgrave
early returns make sense.
Not for this issue but would be neat to eventually have a performance test around caching if possible?
- π¬π§United Kingdom catch
I did think about test coverage here but all we could really do is assert the contents of the cache entry when no routes are found rather than a performance test, which feels a bit too much like repeating what the code does.
- Status changed to Needs work
about 1 month ago 12:45pm 30 July 2024 - Status changed to RTBC
about 1 month ago 12:51pm 30 July 2024 - Status changed to Fixed
about 1 month ago 12:59pm 30 July 2024 - π«π·France nod_ Lille
Committed and pushed da5f6215a9 to 11.x and 41ac5c1446 to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.