- Issue created by @apaderno
- Assigned to Sourav_Paul
- Merge request !8792Issue #3461741: The short description references a form builder function that... → (Open) created by Sourav_Paul
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 10:00am 16 July 2024 - Status changed to Needs work
about 2 months ago 10:08am 16 July 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The line that has been changed is already correct. What needs to be changed is Form submission handler for user_admin_settings()..
- Status changed to Active
about 2 months ago 12:05pm 16 July 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Also, there are more comments which needs to be changed, in that file. Let's expand the issue to those comments too.
- Status changed to Needs review
about 2 months ago 12:13pm 16 July 2024 - Status changed to RTBC
about 2 months ago 12:57am 22 July 2024 - 🇺🇸United States smustgrave
Going to mark it as this does help. Only one I was iffy about is
Saves the contact page setting.
seems like it's not needed since it's a form submission handler.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
@smustgrave Saves the contact page setting. could be removed. I left it because the short description already used it, but it is not necessary, given the code used from that hook.
- 🇳🇿New Zealand quietone New Zealand
The description must say for which form the hook implementation or the form submission handler is.
I can not find a coding standard that support this statement. If someone can point that out, add a link here.
- Assigned to quietone
- 🇳🇿New Zealand quietone New Zealand
@apaderno, thanks for taking the time to update the issue summary directing readers to the standards.
This is certainly an improvement. It does raise the question of if updating these docs for these functions should be done throughout core so we are sure everything is updated.
I intend to commit this within 24 hours.
-
quietone →
committed 98e24c88 on 11.0.x
Issue #3461741 by Sourav_Paul, avpaderno, smustgrave: Add form class to...
-
quietone →
committed 98e24c88 on 11.0.x
-
quietone →
committed 440d09be on 11.x
Issue #3461741 by Sourav_Paul, avpaderno, smustgrave: Add form class to...
-
quietone →
committed 440d09be on 11.x
- Status changed to Fixed
23 days ago 4:29am 16 August 2024 - 🇳🇿New Zealand quietone New Zealand
Committed to 11.x and 11.0.x Thanks for the improvement!
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.