Deprecate country.default schema and remove the value as it is not used any more

Created on 15 July 2024, 3 months ago
Updated 16 July 2024, 3 months ago

Problem/Motivation

Core no longer uses the system.date:country.default value. We should remove it and deprecate the schema. See πŸ“Œ Remove country setting from the installer Fixed and #2276183: Date intl support is broken, remove it β†’

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alexpott
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡¦Ukraine taraskorpach Lutsk

    I've managed to deprecate a config scheme and add a post_update hook. However, I couldn't find a test file where we should check for the deprecation message. Could you help me with that and approve the changes that have already been made?

  • Pipeline finished with Failed
    3 months ago
    #224820
  • Pipeline finished with Failed
    3 months ago
    Total: 589s
    #224833
  • Status changed to Needs work 3 months ago
  • πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

    An example update test would be \Drupal\Tests\locale\Functional\LocalesLocationAddIndexUpdateTest - note you can use the bare db file instead of the filled and it should go in core/modules/system/tests/src/Functional/Update

    Plus this issue is going to need to remove the setting from the form that allows you to set it.

  • πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

    Actually hmmm - looking at contrib usages we have a different story.... see http://codcontrib.hank.vps-private.net/search?text=country.default&filen...

    Actually I think that result calls into question the decision to remove the setting from the installer. What this does mean is that I'm not sure we should do this work.

Production build 0.71.5 2024