Move NavigationShortcutsBlock into the Shortcut module.

Created on 12 July 2024, 5 months ago
Updated 10 August 2024, 4 months ago

Problem/Motivation

This is actually a todo within the code

* @todo Move to Shortcut module as part of the core MR process.

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navig...

Proposed resolution

Move this block into the shortcut module .

Remaining tasks

Move this block into the shortcut module .

User interface changes

N/A

API changes

N/A final class NavigationShortcutsBlock

Data model changes

N/A

Release notes snippet

N/A

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
NavigationΒ  β†’

Last updated about 18 hours ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @trackleft2
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ
  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 1112s
    #244068
  • Pipeline finished with Canceled
    5 months ago
    Total: 127s
    #244204
  • Pipeline finished with Canceled
    5 months ago
    Total: 68s
    #244205
  • Pipeline finished with Success
    5 months ago
    Total: 439s
    #244207
  • Status changed to Needs review 5 months ago
  • Moved the block in shortcut module along with respective test case.

    Please review. moving NR.

  • Status changed to Needs work 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Small comment.

  • Pipeline finished with Success
    5 months ago
    Total: 621s
    #244585
  • Status changed to Needs review 5 months ago
  • Addressed the feedback, Please review moving NR

  • Status changed to RTBC 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    1 comment addressed.

  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

    Shortcut module still works after this change, looks good to me.

  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

    I would like to point out that the block id is still prefixed with navigation_. Not sure if this is what we want. https://git.drupalcode.org/project/drupal/-/merge_requests/9066/diffs#f1...

    If we change it, we may need to write a database update.

  • Status changed to Needs review 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

    I'm marking this as needs review in case my comments should be considered as part of this MR. Feel free to change it back to Reviewed & tested by the community if my comments don't need consideration, sorry for the additional work.

  • Status changed to Needs work 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Don't think the ID needs to change but block does actually need an update. Currently has a check for shortcut but being in the shortcut module this isn't needed but should check navigation.

  • Pipeline finished with Success
    5 months ago
    Total: 606s
    #244709
  • Status changed to Needs review 5 months ago
  • As per feedback, added navigation module check along with comment also updated, not sure apart from it, nothing seems to be left.

    Please review, moving NR.

  • Status changed to RTBC 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Not sure if we will have to move the service too but currently as scoped believe this is good .

  • Status changed to Needs work 4 months ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    ShortcutLazyBuilder should be moved in this issue too, it only exists to support the block.

    I also think we might want to wait to commit this one until the hard blockers for navigation to become stable are committed or at least close to RTBC - otherwise this block will be showing up on the UI on modules without navigation installed while it's still experimental.

Production build 0.71.5 2024