- Issue created by @trackleft2
- First commit to issue fork.
- Merge request !9066Resolve #3461097 "Move navigationshortcutsblock to shortcut" β (Open) created by pooja_sharma
- Status changed to Needs review
5 months ago 9:30am 5 August 2024 Moved the block in shortcut module along with respective test case.
Please review. moving NR.
- Status changed to Needs work
5 months ago 1:48pm 5 August 2024 - Status changed to Needs review
5 months ago 2:32pm 5 August 2024 - Status changed to RTBC
5 months ago 3:20pm 5 August 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Shortcut module still works after this change, looks good to me.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I would like to point out that the block id is still prefixed with
navigation_
. Not sure if this is what we want. https://git.drupalcode.org/project/drupal/-/merge_requests/9066/diffs#f1...If we change it, we may need to write a database update.
- Status changed to Needs review
5 months ago 3:37pm 5 August 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I'm marking this as needs review in case my comments should be considered as part of this MR. Feel free to change it back to Reviewed & tested by the community if my comments don't need consideration, sorry for the additional work.
- Status changed to Needs work
5 months ago 3:46pm 5 August 2024 - πΊπΈUnited States smustgrave
Don't think the ID needs to change but block does actually need an update. Currently has a check for shortcut but being in the shortcut module this isn't needed but should check navigation.
- Status changed to Needs review
5 months ago 4:38pm 5 August 2024 As per feedback, added navigation module check along with comment also updated, not sure apart from it, nothing seems to be left.
Please review, moving NR.
- Status changed to RTBC
5 months ago 4:52pm 5 August 2024 - πΊπΈUnited States smustgrave
Not sure if we will have to move the service too but currently as scoped believe this is good .
- Status changed to Needs work
4 months ago 2:03am 10 August 2024 - π¬π§United Kingdom catch
ShortcutLazyBuilder
should be moved in this issue too, it only exists to support the block.I also think we might want to wait to commit this one until the hard blockers for navigation to become stable are committed or at least close to RTBC - otherwise this block will be showing up on the UI on modules without navigation installed while it's still experimental.