Remove legacy 'metadata' variable from node.html.twig

IIRC there are other weird bits of node.module that exist only to support RDF, we should try to remove those as well eventually.

Fixed the CR link, but has this already been removed? Where is metadata set in $variables anyway? Lots of false positives in grep but I couldn't spot where it is actually set.

Where is metadata set in $variables anyway? Lots of false positives in grep but I couldn't spot where it is actually set.

I had the same problem. It's not set anywhere in core, only in RDF module. So we moved RDF out, and just left the support in the templates. I didn't know that twig allows printing completely null variables but apparently it does.

Seeing that this was for rdf, would this be the place it was set: https://git.drupalcode.org/project/rdf/-/blob/2.x/rdf.module?ref_type=he...

If it is, it was removed from core with the move of rdf to contrib.

Another reason this particular one is crufty is that it only exists because the submitted variable itself is hard-coded in the template. If/when we do ✨ [META] Expose Title and other base fields in Manage Display Active the submitted stuff would be in an extra field, and that would give RDF module the mechanism to add metadata directly alongside it anyway.

Let's add a comment above the deprecation so when we come to this in 12.x we don't have to do the same archaeology to understand it isn't actually used in core.

Added a comment, good plan, it's so confusing.

De-confusing comment confirmed, RTBC for me.

We also need to remove this from the six or so copies of node.html.twig around core, probably except for stable9 where it could stay.

I think readmore is also redundant, can't find where that is set in core either, although removing more stuff here is a bit of scope creep, perhaps we should punt this to a separate issue.

It looks like readmore was removed back in #372743: Body and teaser as fields → !!!

Oh, this is mixed up with 📌 Remove documentation for logged_in and is_admin from node.html.twig Needs work , the last commit here needs reverting.

Removed the stray commit.

I realised this wasn't documented in the deprecation policy so opened 📌 Document how to deprecate Twig variables Active to fix that.

The change record → doesn't say this should be done in preprocess, rather hook_theme, but I guess that doesn't ultimately matter, better to add it close to where it is set? But then the change record should probably be updated to say that too.

I've rebased the branch and removed metadata from profiles and themes.
Pipelines are passing ~~ hence moving into review.
cc: @longwave @catch

Opened an issue against RDF module 📌 $node['metadata'] variable deprecation Active .

MR looks good to me, removing the novice tag.

I did a minor rearranging of the code to keep the teaser setup and its deprecation together, otherwise this looks fine to me so RTBC.

Minor rearranging looks good!

nod_ → closed merge request !8638

Committed c1e7cc2 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.