Drupal 11 fixes for acquia_dam

Created on 2 July 2024, 6 months ago
Updated 3 July 2024, 6 months ago

Problem/Motivation

I can see issue with Drupal 11 when visiting configuration page: /admin/config/acquia-dam

Steps to reproduce

  1. Setup drupal11 site
  2. Enable this module
  3. Login to your site with admin creds
  4. Visit dam configuration page: example.com/admin/config/acquia-dam, you will see WSOD

Proposed resolution

As per the change introduced in core, it is mandatory to provide \Drupal\Core\Config\TypedConfigManagerInterface in ConfigFormBase::__construct

🐛 Bug report
Status

Active

Version

1.1

Component

Code

Created by

🇮🇳India chandu7929 Pune

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chandu7929
  • First commit to issue fork.
  • Merge request !59Issue #3458567: Drupal 11 fixes for acquia_dam → (Closed) created by ankitv18
  • Pipeline finished with Failed
    6 months ago
    Total: 1325s
    #214449
  • Pipeline finished with Failed
    6 months ago
    Total: 1202s
    #214469
  • Pipeline finished with Failed
    6 months ago
    Total: 1051s
    #214490
  • Status changed to Needs review 6 months ago
  • 🇮🇳India ankitv18

    MR!59 is ready for a review.

  • 🇮🇳India chandu7929 Pune

    Changes looks good to me, also verified locally now I am able to access /admin/config/acquia-dam page without any error. Hence RTBC.

  • Status changed to RTBC 6 months ago
  • First commit to issue fork.
  • Pipeline finished with Failed
    6 months ago
    Total: 1464s
    #226302
  • Pipeline finished with Failed
    5 months ago
    Total: 1127s
    #237470
  • Status changed to Needs work 5 months ago
  • 🇮🇳India chandu7929 Pune

    Need to add NEXT_MAJOR.

  • Status changed to Needs review 5 months ago
  • Status changed to Needs work 5 months ago
  • 🇮🇳India chandu7929 Pune

    @Hetal.Solanki we can't move issue in needs review unless CI is green, why do you think its ready for review?

  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Now tested this MR on a D11-rc1 site and although the backend functionality works as expected, but some frontend misalignment occurs on my side with Core's default theme:



    Can anyone else confirm as well?

  • Pipeline finished with Failed
    5 months ago
    Total: 5113s
    #238018
  • 🇮🇳India chandu7929 Pune

    @balu-ertl I don't see such behaviour on a D11-rc1

  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    @chandu7929 we're using different themes. The modal has a black header on my screenshots, yours has a dark blue. What happens if you switch your admin theme to core's Claro, please?

  • 🇮🇳India chandu7929 Pune

    I am testing this on Vanilla drupal D11-rc1 without any customisation, and yes Claro is set as default admin theme.

  • Pipeline finished with Failed
    5 months ago
    Total: 2900s
    #238174
  • Pipeline finished with Failed
    5 months ago
    Total: 2713s
    #238220
  • Pipeline finished with Failed
    5 months ago
    Total: 6499s
    #238296
  • Pipeline finished with Failed
    5 months ago
    Total: 3043s
    #238358
  • Pipeline finished with Failed
    5 months ago
    Total: 2939s
    #238367
  • Pipeline finished with Failed
    5 months ago
    Total: 2646s
    #238377
  • Pipeline finished with Failed
    5 months ago
    Total: 1624s
    #238388
  • Pipeline finished with Failed
    5 months ago
    Total: 2074s
    #238441
  • Pipeline finished with Failed
    5 months ago
    Total: 2887s
    #239144
  • Pipeline finished with Failed
    5 months ago
    Total: 3009s
    #239149
  • Pipeline finished with Failed
    5 months ago
    Total: 2818s
    #239489
  • Pipeline finished with Failed
    5 months ago
    Total: 3156s
    #240202
  • Pipeline finished with Failed
    5 months ago
    Total: 2899s
    #240272
  • Pipeline finished with Failed
    5 months ago
    Total: 2706s
    #240482
  • Pipeline finished with Failed
    5 months ago
    Total: 3688s
    #240670
  • Pipeline finished with Failed
    5 months ago
    Total: 1167s
    #241434
  • Pipeline finished with Failed
    5 months ago
    Total: 2653s
    #241479
  • Pipeline finished with Failed
    5 months ago
    Total: 2665s
    #241480
  • Pipeline finished with Failed
    5 months ago
    Total: 2557s
    #241531
  • Pipeline finished with Failed
    5 months ago
    Total: 2585s
    #241530
  • Pipeline finished with Failed
    5 months ago
    Total: 2725s
    #241589
  • Pipeline finished with Failed
    5 months ago
    #241590
  • Pipeline finished with Failed
    5 months ago
    Total: 2661s
    #241619
  • Pipeline finished with Running
    5 months ago
    Total: 7576s
    #241620
  • Pipeline finished with Failed
    5 months ago
    Total: 2591s
    #241914
  • Pipeline finished with Failed
    5 months ago
    Total: 2748s
    #241913
  • Pipeline finished with Failed
    5 months ago
    Total: 2686s
    #244239
  • Pipeline finished with Failed
    5 months ago
    Total: 2722s
    #244241
  • Pipeline finished with Failed
    5 months ago
    Total: 3182s
    #244286
  • Pipeline finished with Failed
    5 months ago
    Total: 3201s
    #244287
  • Pipeline finished with Failed
    5 months ago
    Total: 2524s
    #244334
  • Pipeline finished with Failed
    5 months ago
    #244335
  • Pipeline finished with Failed
    5 months ago
    Total: 2613s
    #244393
  • Pipeline finished with Failed
    5 months ago
    Total: 2701s
    #244392
  • Pipeline finished with Failed
    5 months ago
    Total: 2736s
    #244480
  • Pipeline finished with Failed
    5 months ago
    Total: 2794s
    #244481
  • Pipeline finished with Failed
    5 months ago
    Total: 2735s
    #244552
  • Pipeline finished with Failed
    5 months ago
    Total: 2737s
    #244553
  • 🇮🇳India chandu7929 Pune

    All tests for D10 & D11 has been fixed. Need to check failing test for D9.5

  • Pipeline finished with Failed
    5 months ago
    Total: 2629s
    #244646
  • Pipeline finished with Failed
    5 months ago
    Total: 2641s
    #244645
  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 954s
    #245225
  • Merge request !65Resolve #3458567 "Drupal11 fixes" → (Merged) created by japerry
  • Pipeline finished with Skipped
    5 months ago
    #253384
  • Merge request !66Resolve #3458567 "Drupal11 fix2" → (Merged) created by japerry
  • Pipeline finished with Failed
    5 months ago
    Total: 1388s
    #253401
  • Pipeline finished with Skipped
    5 months ago
    #253420
  • Status changed to Fixed 5 months ago
  • 🇺🇸United States japerry KVUO
  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Balu Ertl changed the visibility of the branch 3458567-drupal11-fixes to hidden.

  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Balu Ertl changed the visibility of the branch 3458567-drupal-11-fixes to hidden.

  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Balu Ertl changed the visibility of the branch 3458567-drupal11-fixes to active.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024