Contrib.social

Add tests for testing the formatter and its settings (data attributes)

Open on Drupal.org →
Created on 2 July 2024, 9 months ago
Updated 19 September 2024, 7 months ago

Problem/Motivation

We currently lack tests, testing the formatter and its settings. We only have simple generic tests implemented for now.

We should add tests applying the formatter to an image field and checking, whether changing display settings will have any effect on the data-attributes applied through the formatter.

Steps to reproduce

Proposed resolution

Add tests for testing the formatter and its settings.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Grevil
  • Comment 9 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    Yeah cross-checking the data attributes in the output totally makes sense. Good idea.

    Happy to review a MR if someone implements this. I'm going to tag this novice for such tests.

  • First commit to issue fork.
  • Merge request !1Added test code for formatter → (Open) created by java008
  • Pipeline finished with Failed
    9 months ago
    Total: 158s
    #221607
  • Pipeline finished with Failed
    9 months ago
    Total: 141s
    #221803
  • Pipeline finished with Failed
    9 months ago
    Total: 135s
    #222051
  • Pipeline finished with Failed
    9 months ago
    Total: 163s
    #222074
  • Pipeline finished with Failed
    9 months ago
    Total: 143s
    #222198
  • Pipeline finished with Failed
    9 months ago
    Total: 138s
    #222203
  • Pipeline finished with Failed
    9 months ago
    Total: 138s
    #222204
  • Pipeline finished with Failed
    9 months ago
    #222214
  • Pipeline finished with Failed
    9 months ago
    Total: 134s
    #222415
  • Pipeline finished with Failed
    9 months ago
    Total: 164s
    #222423
  • Pipeline finished with Failed
    9 months ago
    Total: 150s
    #222432
  • Pipeline finished with Failed
    9 months ago
    Total: 235s
    #222443
  • Pipeline finished with Failed
    9 months ago
    Total: 158s
    #222459
  • Pipeline finished with Success
    9 months ago
    Total: 135s
    #222467
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    @java008 thanks for your initial work! Still I can't see tests that check the expected data attributes to be present, are you planning to proceed?

  • Comment 7 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    @java008 any further plans here to implement the data attribute checking? Or anyone else?
    Otherwise this can't be credited, sorry.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024