- Issue created by @Hetal.Solanki
- Assigned to dev2.addweb
- š®š³India Hetal.Solanki
Hetal.Solanki ā changed the visibility of the branch 3458455-dev to hidden.
- Assigned to Hetal.Solanki
- Status changed to Needs review
2 months ago 8:12am 2 July 2024 - Issue was unassigned.
- Status changed to Needs work
2 months ago 8:19am 2 July 2024 - š®š³India bhaveshdas
i have tested MR 2 and i have found some error below:-
use below this command-:vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/custom/vpn_login-3458455/FILE: /var/www/html/drupal-contri-d10/modules/custom/vpn_login-3458455/src/EventSubscriber/LoginSubscriber.php -------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------------------- Time: 109ms; Memory: 10MB
- Status changed to Needs review
2 months ago 12:43pm 4 July 2024 - š®š³India dev2.addweb
Hi,
I have fixed phpcs issue mention in #7, Please review it. - Status changed to RTBC
2 months ago 11:17am 5 July 2024 - šµšPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!2, it was applied cleanly and fixes the issues.
ā vpn_login git:(main) ā curl https://git.drupalcode.org/project/vpn_login/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5445 0 5445 0 0 10702 0 --:--:-- --:--:-- --:--:-- 10718 patching file src/EventSubscriber/LoginSubscriber.php patching file src/EventSubscriber/RouteSubscriber.php patching file src/Form/VpnLoginConfigForm.php patching file vpn_login.services.yml ā vpn_login git:(main) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml vpn_login FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/vpn_login/vpn_login.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- Time: 150ms; Memory: 10MB ā contrib git:(main) ā
Please ignore the issues that I encountered since it is because I downloaded the module via composer.
I am now moving this to Reviewed & tested by the community.
Thank you.
-
smulvih2 ā
committed 66a52a73 on 1.0.x-dev
Issue #3458455: Fix the issues reported by phpcs
-
smulvih2 ā
committed 66a52a73 on 1.0.x-dev
- šØš¦Canada smulvih2 Canada š
Thanks for all your work on this! Merged wth 1.0.x-dev and will be included in next release.
- Status changed to Fixed
about 2 months ago 1:33pm 23 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.