- Issue created by @sophron
- First commit to issue fork.
misterdidi β changed the visibility of the branch 3457768-views-fieldset-labels to hidden.
misterdidi β changed the visibility of the branch 3457768-views-fieldset-labels to active.
After digging into the code, I found out that :
- Claro module moved its file responsible for the styling of tabscss/components/views-ui.css
from global-styling library to a new one called views_ui which extends views/views.module library.
- views/views.module is attached to any new ViewExecutable object through its $element property and used in the render array of Drupal\views\Plugin\views\display\DisplayPluginBase::render().
- for Entity Reference display, the display plugin Drupal\views\Plugin\views\display\EntityReference overrides its parent render() function and does not attach the view $element property to the render array. Hence, views/views.module is never attached and the claro/views_ui never used for an Entity Reference display.I wrote a patch in which I chose to alter the render() method of EntityReference to mimic DisplayPluginBase::render() and always return the view $element['#attached'] value with the render array.
- Status changed to Needs review
8 months ago 3:37pm 28 June 2024 - π΅πΉPortugal lolgm
I believe this issue is a part of π Secondary tabs design is distorted on block view page Active .
If it really is, I believe this is a duplicate.
- Status changed to Postponed: needs info
8 months ago 1:56pm 1 July 2024 - πΊπΈUnited States smustgrave
@misterdidi can you confirm if this is a duplicate? If not it should go back to Needs work though as will need an MR to review.
- Status changed to Closed: duplicate
8 months ago 10:01pm 1 July 2024 - πΊπΈUnited States traviscarden
Confirmed: This is a duplicate of π Secondary tabs design is distorted on block view page Active . The problem there (
view-ui.css
is missing) is the cause here, too, and adding it fixes the problem in both cases.