- Issue created by @erdm
flexible_permissions module will be bumped to v2
see https://www.drupal.org/project/group/issues/3449620#comment-15616570 π Bump minimum core version to 10.3 Fixed
flexible_permissions v2 does not have dependency on variationcache module https://git.drupalcode.org/project/flexible_permissions/-/blob/2.0.0/fle...- π¬π§United Kingdom jaydenpearly
Who said flexible permissions v2 does have dependency on variation cache module .
I don't understand why you feel the need to repeat the topics I wrote and touched upon.
I created this issue to talk about reducing the group module's dependency on other separated modules. I also shared topics related to other modules. This isn't just about flexible permission.
I recommend you read it again. I think the main idea and situation I mentioned above can be clearly understood.
Anyway, I won't change the title you changed, lets keep it that way. We will find a solution eventually. - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
In order to drop dependencies I need to release a new major (Group 4). My current goal is to release 3.3.x/2.3.x with an upgrade path from 2 to 3. Then we can start working on v4 where we drop all the dependencies. The new Group release can already depend on FP v2, which would be a trivial change to make.
- π·π΄Romania claudiu.cristea Arad π·π΄
claudiu.cristea β made their first commit to this issueβs fork.
- Status changed to Needs review
4 months ago 5:48pm 11 August 2024 - π¦πΉAustria mvonfrie
Using Core 10.3.1, Group 3.2.2 and Flexible Permissions 1.10, I repeatedly but not really reproducable get the following (unhandled) errors:
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "group.anonymous_user_response_subscriber", path: "group.anonymous_user_response_subscriber -> group_permission.calculator -> flexible_permissions.chain_calculator". in Drupal\Component\DependencyInjection\Container->get() (Zeile 149 in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php)
TypeError: Drupal\flexible_permissions\ChainPermissionCalculator::__construct(): Argument #1 ($cache) must be of type Drupal\variationcache\Cache\VariationCacheInterface, Drupal\Core\Cache\VariationCache given, called in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 in Drupal\flexible_permissions\ChainPermissionCalculator->__construct() (Zeile 63 in /var/www/html/web/modules/contrib/flexible_permissions/src/ChainPermissionCalculator.php).
They always appear together in the logs.
Maybe they will be resolved when upgrading to Flexible Permissions V2? If not please let me know to open a separate issue.
- π¦πΊAustralia realityloop
This change appears to be in place on 3.3.x-dev already now.
- πΊπΈUnited States Greg Boggs Portland Oregon
Unless I'm just missing it, this does not appear to be in 3.3.x-dev yet? I ended up here because 3.3.x still installed varation cache and varationcache project page says:
"Please uninstall and remove this module once you are using Drupal 10.2 or higher and have no more code mentioning the Drupal\variationcache namespace."
-
kristiaanvandeneynde β
committed d7f40c8c on 3.3.x
Issue #3455789 by claudiu.cristea, kristiaanvandeneynde: Bump...
-
kristiaanvandeneynde β
committed d7f40c8c on 3.3.x
-
kristiaanvandeneynde β
committed 22af7139 on 2.3.x
Issue #3455789 by claudiu.cristea, kristiaanvandeneynde: Bump...
-
kristiaanvandeneynde β
committed 22af7139 on 2.3.x
- Status changed to Fixed
3 months ago 11:35am 20 September 2024 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Didn't feel like fixing the merge conflict so closed the request and made the changes myself. Thanks all!
Automatically closed - issue fixed for 2 weeks with no activity.