Contrib.social

Layout Builder shouldn't use the default value to determine whether a field has a value or not

Open on Drupal.org →
Created on 10 June 2024, about 1 year ago

Problem/Motivation

This workaround was initially introduced in #3119786: Default values are not displayed for image fields placed in Layout Builder → and added specifically for the image field type.

The default value specified in the field type is typically only used for new entities created within the form display, and not the view display, since it simply provides a default value (which can be deleted if the field is not required).

The image field type is one of the few exceptions which attempts to populate and render a field value even if it actually flags itself as empty.

Attempting to support this image-specific edge case has caused a knock-on effect affecting other fields, and as long as they have a default value specified, then a label will always be attached regardless of if the underlying field is empty which shouldn't be the case.

Steps to reproduce

  1. Add a simple field with a default field value to a content type.
  2. Create a piece of content with that field empty.
  3. Add that field block in Layout Builder, and it'll show the field label on the front-end

Proposed resolution

Following options are available:

Remaining tasks

Discussion/PR.

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

🐛 Bug report
Status

Active

Version

11.0 🔥

Component
Layout builder  →

Last updated about 7 hours ago

Created by

codebymikey

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @codebymikey
  • Merge request !8362Issue #3453694: Layout Builder shouldn't use the default value to determine whether a field has a value or not → (Open) created by codebymikey
  • Pipeline finished with Failed
    about 1 year ago
    Total: 665s
    #195643
  • Status changed to Postponed: needs info about 1 year ago
  • Comment about 1 year ago →
    🇳🇿New Zealand danielveza Brisbane, AU

    Hello! Thank you for raising a very detailed issue.

    Could you please confirm that the steps to reproduce in the IS are with a fresh install of Drupal 11? If not can they be updated with the steps to reproduce starting with a fresh install of D11?

    I'm asking because I've tried to this and I've been unable to replicate this. The steps I've followed are below:

    • Fresh install of a standard D11 site
    • Enabled LB
    • Added Layout builder to articles
    • Added a text field to articles with a default value of "Default text"
    • Created a new article and removed the default value from the field
    • Went to LB for the article and added the fieldblock for the new field.
    • I'm not able to see the label as described in the IS

    Thanks!

  • Comment about 1 year ago →
    codebymikey

    Yes, this is replicable on a clean installation using Simplytest. And sorry I mispoke, the behaviour more apparent when the "Display title" option is ticked on the block.

    Relevant links available here (username: admin, password: admin):

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    codebymikey
  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 640s
    #483502
  • Pipeline finished with Failed
    3 months ago
    Total: 536s
    #483510
  • Pipeline finished with Failed
    3 months ago
    Total: 522s
    #483520
  • Pipeline finished with Failed
    3 months ago
    Total: 688s
    #483524
  • Pipeline finished with Success
    2 months ago
    Total: 668s
    #483528
  • Comment 2 months ago →
    🇮🇳India nmudgal

    Updated the patch to fix all related test failures:

    • LayoutBuilderDefaultValuesTest: Adjusted alt text and file name checks to correctly match fields with storage/instance defaults. Updated string field checks for default value handling.
    • FieldBlockTest: Fixed access check logic when a field is empty but has a default value. Access should be allowed in that case.
    • BlockFilterTest: Adjusted block filter assertions to handle variations in block counts when filtering by text like "ad" or "adm".
  • Comment 2 months ago →
    🇺🇸United States smustgrave

    Seems more like a feature request and disruptive one for existing sites

  • Comment 2 months ago →
    🇮🇳India sagarmohite0031

    Hello,
    Tested and verified on Drupal 11,
    Not able to reproduce the issue,
    Working fine for me.
    Check attachments

  • Comment about 2 months ago →
    🇮🇳India snehal-chibde

    Hello, I have tested the MR on Drupal 11. It is working as expected.

    The steps I've followed are below:

    Enabled LB on Drupal 11.
    Added Layout builder to article content type.
    Added a text field to articles with a default value of "some deafult text".
    Created a new article and removed the default value from the field.
    Went to LB for the article and added the field block for the new field with the "Display title" option ticked.
    Despite the field having empty value the title was visible.

    After the MR was applied the layout builder's field title was no more visible when field value is empty.
    Added before and after screenshots for reference.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024