Disable autosubmit with media query

I have added field to the "Exposed form options" form for media query and added checking this media query before triggering the submit button. Could someone review these changes, pls?

Tested, works good

Will need an upgrade path and schema validation most likely

So for this one I don't think we should assume site builders know how to write media queries. Instead maybe the field should be a number field that sets up the media query.

We can use the breakpoint core module instead of the media query string. In this case, all breakpoints will be defined in the yml files, and the site builders will choose which one they want to use in the select list.

I'd be fine with that approach!

I have implemented the breakpoint approach in the 3452004--disable-autosubmit-with-7x branch.

Thanks, will probably need an upgrade hook for the new key

Hey I just checked the implementation in the MR and I am not sure if we want to rely on the breakpoints that are defined in the YAML file. What would you think about using a JS condition for this, e.g.

if ('ontouchstart' in window)

chizh273 → changed the visibility of the branch 7.1.x to hidden.

chizh273 → changed the visibility of the branch 3452004--disable-autosubmit-with-7-1-x to hidden.

The merge conflict is resolved.

I'd say that we don't need an upgrade hook for the new key because these changes shouldn't affect any existing configurations. We have a whether breakpoint is not empty check, and the default value is an empty string, so existing configurations will skip the breakpoint part till it's configured.

I don't think it will work as expected, as `ontouchstart` can be emitted on laptops with a touchscreen. Also, it wouldn't give us as much flexibility as breakpoints. For example, you have views with filters, which are hidden in a modal on mobile and tablet vertical orientation, but they are visible on tablet horizontal orientation and desktop. This means that filters shouldn't be auto-submitted when they are in modal, but they should be when they are visible on the page. So, from my point of view, the best way to implement it is with breakpoints, as you'd have a lot of flexibility and would reuse existing breakpoints from your theme.

New keys should have an upgrade hook, if the key isn’t appearing then something seems wrong

The hook update is added