- Issue created by @chizh273
- Status changed to Needs review
10 months ago 3:47pm 2 June 2024 - πΊπ¦Ukraine chizh273
I have added field to the "Exposed form options" form for media query and added checking this media query before triggering the submit button. Could someone review these changes, pls?
- Issue was unassigned.
- Status changed to RTBC
10 months ago 9:26am 3 June 2024 - Status changed to Needs work
10 months ago 12:06pm 3 June 2024 - πΊπΈUnited States smustgrave
Will need an upgrade path and schema validation most likely
- πΊπΈUnited States smustgrave
So for this one I don't think we should assume site builders know how to write media queries. Instead maybe the field should be a number field that sets up the media query.
- πΊπ¦Ukraine chizh273
We can use the
breakpoint
core module instead of the media query string. In this case, all breakpoints will be defined in the yml files, and the site builders will choose which one they want to use in the select list. - Merge request !156Issue #3452004 by chizh273: Disable autosubmit with breakpoint. β (Open) created by chizh273
- πΊπ¦Ukraine chizh273
I have implemented the breakpoint approach in the
3452004--disable-autosubmit-with-7x
branch. - πΊπΈUnited States smustgrave
Thanks, will probably need an upgrade hook for the new key