[2.x] IEF Complex Widget Dialog

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. FILE: ief_popup.info.yml

core_version_requirement: ^8 || ^9 || ^10 || ^11

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

2. FILE: ief_popup.module

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.

Let's keep this application open for longer.
I usually close applications created a year ago, for which no reply from the applicant has been posted in the past eight months.

Hello @vishal.kadam. I'm a co-maintainer for the ief_popup module. I've since released a new semver 2.2.x dev branch that addresses the points in your project review. Could you please review the ief_popup project again and let me know how we may proceed with the security advisory application? I've been in touch with @dataweb and he has accepted my help in co-maintaining the module and making the changes.

This is Bert Jansen (dataweb)'s application, meaning that:

• Only Bert Jansen (dataweb) is allowed to make commits on the project while the application is open.
• Only Bert Jansen (dataweb) can change the status to "Needs review."

The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code which follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.

@avpaderno, could you please advise on how to proceed with this security advisory application?

@vishal.kadam What you said in your previous comment is right.
Since the changes done from chrisck are in a new branch, the branch created from dataweb has not been touched. It means dataweb can still use this application.

Thank you for the clarity @vishal.kadam. We'll wait for @dataweb's response.