Automated Drupal 11 compatibility fixes for workflow_buttons

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

I tested this with Drupal 11, and ran into an error when using the widget in the display due to the assert asserting the wrong type. I've fixed that issue, and tested that the module now works as expected with Drupal 11.

When using the Gin theme, in the new update of the theme version 8.x-3.0-rc14 → , the buttons appear hidden in the "More actions" dropdown, which is not intuitive.

The Cannot opt out buttons using #gin_action_item = TRUE 🐛 Cannot opt out buttons using #gin_action_item = TRUE Active patch is also necessary for the Gin theme, which is pending integration.

@joseminosa, I'm sorry for the very slow reply. Are you reporting that the other issue is important, or are you reporting a new issue besides the one in that other issue?

I'm setting this back to "Needs work" since the patch from MR15 doesn't apply to the latest -dev release.

In the process of testing the -dev upgrade on Drupal 10, I encountered the assertion problem mentioned by @ultrabob in this issue, so this is not specifically a Drupal 11 problem. I've proposed breaking that out to a separate issue to help simplify this one focused on Drupal 11 compatibility only. See 🐛 Assertion for entity.form_builder service is incorrect Active .

As far as I can tell, from the latest -dev release, the only changes needed to make this module (and submodule) D11-ready is to add ^11 to each of the .info.yaml files, as in the original automated updates in #4 📌 Automated Drupal 11 compatibility fixes for workflow_buttons Active . Upgrade Status module scans report no other issues if you make these changes.

I've updated the MR to be mergeable into the latest changes in 8.x-1.x. Setting back to 'Needs review' -- based on the previous comment, this should be able to be set to RTBC forthwith.

Thanks @mark_fullmer I looked at the commit and confirmed there is nothing there to be alarmed about. Back to RTBC

There is something wrong with this issue fork. The patch in MR!15 may apply to 8.x-1.x in this issue fork, but it does not apply against the 8.x-1.0-beta6 release, nor does it apply against the latest 8.x-1.x of the actual project.

First of all, this fork's 8.x-1.x branch should be rebased against the project 8.x-1.x, as it is currently at the beta6 tag. I tried to do so, but don't have push access.

Second, there is something odd with this "project-update-bot-only" branch which prevents the MR!15 patch to be applied outside this fork. Attempting to apply the MR!15 patch to either the beta6 tag or the most recent 8.x-1.x of the module results in the following rejection to be generated. a.k.a workflow_buttons.module.rej:

@@ -105,7 +105,7 @@
       'workflow_buttons' => TRUE,
     ];
     $form_builder = \Drupal::service('entity.form_builder');
-    assert($form_builder instanceof FormBuilder);
+    assert($form_builder instanceof EntityFormBuilderInterface);
     try {
       $form = $form_builder->getForm($entity, 'default', $form_state_additions);
     }

I've tried to figure out how this discrepancy crept in, and so far have not figured things out. Basically, assert($form_builder instanceof FormBuilder); doesn't exist in either (beta6 or the module's latest 8.x-1.x), so the patch fails to find the line to remove.

Hopefully someone more familiar with this module's history can figure it out. As it is, someone trying to get their implementation of this module ready for Drupal 11 is going to have a hard time.

Basically, assert($form_builder instanceof FormBuilder); doesn't exist in either (beta6 or the module's latest 8.x-1.x), so the patch fails to find the line to remove.

It exists here: https://git.drupalcode.org/project/workflow_buttons/-/blob/8.x-1.x/workf...

It is not in the 1.0-beta6 release, since that tag occurs prior to the two commits that introduced, and then modified that code:

Introduced: https://git.drupalcode.org/project/workflow_buttons/-/commit/a3badee0e30...
Modified: https://git.drupalcode.org/project/workflow_buttons/-/commit/f4d5631ddc6...

So we are not going to have a single patch that applies both to the 8.x-1.x branch and 8.x-1.0beta6.

I've created a new branch / merge request, confirmed it has all the commits present in the 8.x-1.x branch, and replayed the relevant D11-compatibility changes, omitting code syntax cleanup since that should be considered out of scope for D11 compatibility solely.

mark_fullmer → changed the visibility of the branch project-update-bot-only to hidden.

I have checked the patch from @mark_fullmer's MR over 8.x-1.x-dev along with composer-drupal-lenient plugin. It works fine on D11.1.6.

Attaching the patch here for convenience.

A new branch should be created for D11. I really like and use this module a lot, I'm happy to assist if anything is needed.