Ckeditor Media Resize breaks all ckeditor fields

Actually may be a conflict with https://www.drupal.org/project/ckeditor5_embedded_content →

I see this too on a site with several contrib ckeditor plugins.

Disabling various combinations of plugins seems to break ckeditor when aggregation is one. Once if which is this module.

Can't see any errors in console when aggregated or not.

Have tried with the patch in 🐛 Drupal core 10.3 breaks compatibility with CKEditor5 API Fixed but still see the same issue.

Ok - this was very difficult to reproduce outside of the site I had in question.

I was not able to reproduce it on a clean install with just ckeditor_media_resize enabled / configured with aggregation enabled.

I then started one by one trying to replicate additional things that were on the site in question - various config options and module enabled seemed to trigger this - but the one consistency was this module being enabled.

I could observe that the aggregate JS was loading and the plugin JS was loading outside the aggregate. Several modules I had in use appeared to use this pattern.

After removing preprocess: false from the libraries definition I have not been able to reproduce the error.

I'm suspect something around the aggregation and plugin loading is flaky? Maybe not specific to this module - but I'm not overly familiar with the plugin so perhaps there is something module specific at play here.

Either way - I can't see any specific reason why the plugin should be excluded from the aggregate - a quick google showed that core plugins removed preprocess: false in 9.3 - in 🐛 Ckeditor Media Resize breaks all ckeditor fields Active

Perhaps somebody more familiar with the ins and outs of CKEditor plugins will know more - but that change seems to fix the issue for me.

@smustgrave - I am curious if you are still able to reproduce this issue with your setup?

I had a very similar situation, but it was removing the Media Embed icon from the toolbar which fixed the situation rather than the Media Resize filter (which didn't solve it) so the problem may be somewhere in the core Media module.

Actually believe this can be closed a duplicate of 🐛 Drupal core 10.3 breaks compatibility with CKEditor5 API Fixed . Once applying the fix from over there everything works as expected. Only RTBC so it puts it in front of hte maintainers to move over credit.

Thanks for working through this.

I am still experiencing this error on my install with Drupal 10.3.2 and ckeditor_media_resize 1.0.0-beta2 or 1.0.x-dev.

+1 that its still an issue.

I mentioned in #3 that I was testing with the patch from the now committed #3458385 in place - I don't think this is a duplicate issue.

@visios I can see you also have JS aggregation enabled - does it work for you with aggregation disabled? And if so, would you be able to test MR11?

I was never able to find the root issue but for me allow the plugin JS to be aggregated made the issue go away completely.

I don't see a reason why the module should not allow the plugin JS should be not be aggregated.

Yes, the module works fine with JS aggregation disabled. I tried the MR you mentioned but unfortunately the problem persists.

Ah thanks for testing, that is a shame - I suspect I will hit this error again at some point.

Do you have any other ckeditor plugins forcing a break in aggregation?

If you are happy to share other ckeditor contrib you have in use I can compare it to my setup where I was able to reproduce the issue.

I'm having the same issue when aggregation is enabled.

I have two other CKEditor modules enabled: CKEditor IndentBlock → and CKEditor5 Fullscreen → .

I uninstalled CKEditor5 Fullscreen and the issue was resolved.

I then re-installed CKEditor5 Fullscreen and uninstalled CKEditor IndentBlock and the issue was NOT resolved.

🐛 CKEditorError: plugincollection-plugin-not-found Needs work eventually did the same fix as MR11 - I had missed that this was reopened as active rather than needs review - happy the fix got in eventually :)

ericgsmith → closed merge request !11