Automated Drupal 11 compatibility fixes for mimemail

Open on Drupal.org →

Created on 21 May 2024, 11 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

If the issue is reopened, then new automated changes will be posted.

If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

Review the merge request and test it.
Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task

Status

Needs review

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.

ProjectUpdateBotD11

Drupal 11 compatibility

Sign in to follow issues

Merge Requests

!17Automated Drupal 11 compatibility fixes for mimemail
Open
project update bot
updated 10 months ago
!16Automated Drupal 11 compatibility fixes for mimemail
Open
project update bot
updated 10 months ago

Comments & Activities

Issue created by @project update bot
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update 11 months ago
28 pass
Comment 11 months ago →
project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-177898

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.1

mglaman/phpstan-drupal: 1.2.11

palantirnet/drupal-rector: 0.20.1
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update 10 months ago
25 pass, 3 fail
Comment 10 months ago →
project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.1

mglaman/phpstan-drupal: 1.2.11

palantirnet/drupal-rector: 0.20.1
Merge request !16Draft: Automated Project Update Bot fixes → (Open) created by project update bot
Comment 10 months ago →
System Message
The last submitted patch, 3: mimemail.1.x-dev.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Needs review 10 months ago4:12pm 2 June 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update 10 months ago
25 pass, 3 fail
Comment 10 months ago →
project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2

mglaman/phpstan-drupal: 1.2.11

palantirnet/drupal-rector: 0.20.2
Comment 10 months ago →
System Message
The last submitted patch, 6: mimemail.1.x-dev.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Needs review 10 months ago2:23am 18 June 2024
Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
1:16
1:16
Queueing
Comment 10 months ago →
project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2

mglaman/phpstan-drupal: 1.2.11

palantirnet/drupal-rector: 0.20.3
Merge request !17Automated Project Update Bot fixes → (Open) created by project update bot
Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
1:01
1:01
Queueing
Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
0:58
0:58
Queueing
Pipeline finished with Failed
10 months ago
Total: 157s
#201535
Pipeline finished with Failed
10 months ago
Total: 159s
#201537
Pipeline finished with Failed
10 months ago
Total: 194s
#201536
Comment 10 months ago →
System Message
The last submitted patch, 8: mimemail.1.x-dev.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Closed: outdated 8 months ago8:03am 28 July 2024
Comment 8 months ago →
🇺🇸United States tr Cascadia
Comment 7 months ago →
🇵🇰Pakistan TanvirAhmad
Call to deprecated method renderPlain() of interface Drupal\Core\Render\RendererInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal\Core\Render\RendererInterface::renderInIsolation() instead.
Status changed to Needs review 4 months ago9:09pm 28 November 2024
Comment 4 months ago →
🇨🇦Canada joseph.olstad
Comment 4 months ago →
🇨🇦Canada joseph.olstad
patch
Comment 4 months ago →
🇨🇦Canada joseph.olstad
ok, I was confused, there's a 2.0.x branch at the bottom of the project page, perhaps it should be the recommended instead of the 8.x-1.x
Comment 4 months ago →
🇨🇦Canada joseph.olstad
task would be to tag a 2.0-alpha1 release and mark it as recommended instead of the 1.0-alpha
Comment 4 months ago →
🇨🇦Canada joseph.olstad
also, the 2.0.x branch should be the default branch instead of 8.x-1.x
Comment 4 months ago →
🇺🇸United States tr Cascadia
the 2.0.x branch should be the default branch instead of 8.x-1.x

? The 2.0.x branch IS the default when you checkout the project.

I have though of using alpha/beta etc., but the problem is no one will use them because everyone uses "stable" for their "minimum-stability" constraint in core composer, and nothing other than a full release will satisfy that requirement. You have to relax that requirement to install an alpha/beta, or dev. So because of that dev is just as good as alpha, and IMO it is a more honest statement - this is not alpha ready. I'm not requiring it to be bug free before a stable release, but handling embedded images correctly is really a very basic expectation even for alpha code.

Changing the @var comment in your patch literally does nothing. Phpstan doesn't even complain about that. That's why that section of code needs to be fixed - embedded images are not being handled correctly and a documentation comment won't fix that. ✨ Improve image detection Needs work needs to be finished and we need tests to prove it does the right thing.

And I want to keep *this* issue closed. It illustrates what I explained in my previous reply to you, that the bot doesn't provide useful patches (note that the MR!16 is a patch against MimeMail 4.6.x-1.x, as in the Drupal core 4.6 version of this module ...) The MR!17 is against 8.x-1.x, which won't be made compatible with D11 because D11 is only going to be supported in 2.0.x and higher. And, the MR!17 is full of changes that were already made. Likewise, leaving this open attracts totally out of scope things like #12 which was already fixed in 2.0.x and which doesn't even need to be fixed for D11 compatibility. The bot will continue to post patches in this issue as long as it is open.

I appreciate your trying to help, but the big things already have open issues and that's where these issues should be addressed. An issue like this one doesn't help progress towards a stable release.
Status changed to Closed: outdated 2 months ago9:20am 4 February 2025
First commit to issue fork.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024