Automated Drupal 11 compatibility fixes

ankitv18 → changed the visibility of the branch 3448524-automated-drupal-11 to hidden.

All deprecation warnings are fixed with d11 support and phpunit tests are passing now, please review MR!13

Dropping the support for D9 with the respect https://www.drupal.org/node/3305664 →

@ankitv18 → : I think we shouldn't remove support for D9 based on what's mentioned in https://www.drupal.org/node/3305664 → .
We should update selector,
FROM:
#drupal-off-canvas-wrapper
TO

#drupal-off-canvas:not(.drupal-off-canvas-reset),
#drupal-off-canvas-wrapper {
}

Added both attribute #drupal-off-canvas:not(.drupal-off-canvas-reset), #drupal-off-canvas-wrapper in the CSS and JS
Created new issue for fixing previous major phpunit failure.

RTBC + 1

Hello Samuel & Joël,

Could you please confirm that you are still maintaining this module as there hasn't been any activity over the past year. We would also appreciate if you could update us about your plans to release a pre/stable version of moderation_sidebar so that we can use it in our application that supports Drupal 11. Thanks!

Hello Samuel & Joël,

Please accept my apologies for bothering you, but I would appreciate it if you could release a Drupal 11 compatible version as we have put in a great deal of effort to fix the compatibility issues. If you are no longer maintaining this, please add me as a maintainer, so we can provide support for Drupal 11 customers that will be very helpful in the long run.

Thanks!

Hello Joël & Samuel,

Would it be possible to release a Drupal 11 compatible version before the Drupal 11 stable version is released next week?

Thanks!

Left a few questions on the MR. Coding standards shouldn't be mixed with D11 compatility issues, this makes this issue way harder to fix than it has to be.

I expected to see 📌 Schema for moderation_sidebar.settings.workflows is in deprecated format Needs work as part of this, not sure if it's not failing then I guess there are no tests covering that feature.

This needs to be peeled back to just the relevant changes to be D11 compatible.

@acbramley the class EntityTestMulRevPub requires entity_test_mulrevpub schema to be enabled which is currently not happening and hence tests are failing for all the versions of Drupal. To fix this we need to either switch test to kernelTestBase or use node::create in BrowserTestBase.

deepakkm → I don't agree with this explanation; we just have to add these two lines of code, which will do the work; no update is required in any of the tests files.

diff --git a/tests/src/Functional/ModerationSidebarTest.php b/tests/src/Functional/ModerationSidebarTest.php
index a678462..ea3f71f 100644
--- a/tests/src/Functional/ModerationSidebarTest.php
+++ b/tests/src/Functional/ModerationSidebarTest.php
@@ -62,6 +62,10 @@ class ModerationSidebarTest extends BrowserTestBase {
       'name' => $this->randomMachineName(),
     ]);
     $entity->save();
+
+    $user = $this->createUser([], '', true);
+    $this->drupalLogin($user);
+

Created separate MR!17 with minimum required changes for D11, fixes hence requesting review.

Hello @ japerry → , Can you please confirm if we have to keep support for D9 with respect to the comment 📌 Automated Drupal 11 compatibility fixes Needs review otherwise we are good.

The MR has some conflicts

Drupal 9 support should not be dropped yet, so its been retained and the phpunit tests fixed in another issue. Since the D11 issue isn't making those tests fail again in d9, and appears to be working in D10 and 11 I think we're good here.

I added a test for the config form. While I'm not sure it'll pick up schema errors, it would pick up the deprecation as a failed test in D11.

Committed!

@japerry if we are supporting D9.5 then please include this commit https://git.drupalcode.org/project/moderation_sidebar/-/merge_requests/1...
as per CR: https://www.drupal.org/node/3305664 →

We also need to include this change for D9 from js/moderation_sidebar.js

  // information is already available.
  $('.toolbar-icon-moderation-sidebar').on('click', function (e, data) {
    if ($('.moderation-sidebar-container').length && (!data || !data.reload)) {
      $('#drupal-off-canvas-wrapper, #drupal-off-canvas').dialog('close');
      e.stopImmediatePropagation();
      e.preventDefault();
    }

@japerry if we are supporting D9.5 then please include this commit https://git.drupalcode.org/project/moderation_sidebar/-/merge_requests/1...

There was a piece missing from the original MRs regarding the CSS, so I committed that. Thanks chandu7929 for pointing out the js BC as well. thats been committed!

japerry → closed merge request !21

japerry → closed merge request !13

Hey @japerry I've noticed this on a few issues of yours now but you seem to be forgetting to give credit for all the people that worked on these issues. Many people on this issue were not credited for their work. Hopefully this is just an oversight, would appreciate you fixing it up. Thanks!

My apologies, apparently d.o doesn't show MR comments in the issue, so I didn't see your guys reviews. Ultimately those branches weren't used, which is why you only see the credit with chandu7929 from comment #33. Fixed!

Thanks a lot @japerry!

But the actual work done by me most of the file changes are taken as reference from the MR!13 even drupal-wrapper-off-canvas BC support was totally done over their at first place.

Also most of the linked and related issues either I've raised them or worked on the them but didn't get a credit not sure why.

The CSS changes don't work with D10. Specifically, the ".ui-dialog-off-canvas #drupal-off-canvas-wrapper" selector doesn't work, "#drupal-off-canvas-wrapper" is the same element as ".ui-dialog-off-canvas". I'm not sure if this patch will mess up specificity or something but it works in D10 for me. See screenshots for what I saw on stock d10 install and 8x-1.8.

Created https://git.drupalcode.org/project/moderation_sidebar/-/merge_requests/23 I have no idea how MRs work still

Automatically closed - issue fixed for 2 weeks with no activity.