- Issue created by @akalam
- Merge request !7927Issue #3445425: \Drupal\Core\Template\Attribute should implement Countable interface → (Open) created by akalam
- Status changed to Needs review
8 months ago 9:35am 6 May 2024 - 🇪🇸Spain akalam
Provided a MR and uploaded a static patch implementing the countable interface in the Attribute object
- Status changed to RTBC
7 months ago 3:08pm 27 May 2024 - 🇺🇸United States smustgrave
Change seems non-disruptive. Only question for committers is if we need a CR?
- Status changed to Needs work
7 months ago 9:49pm 28 May 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Let's add a simple test for this.
\Drupal\Tests\Core\Common\AttributesTest would be a good spot.
- First commit to issue fork.
I'm sorry i messed this up because of the target branch.Will fix this soon
- Status changed to Needs review
7 months ago 5:46am 31 May 2024 Created a new branch pointing to 11.x branch and also added the test for the fix.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3445425-drupalcoretemplateattribute-should-implement to hidden.
- Status changed to Needs work
7 months ago 1:47pm 31 May 2024 - 🇺🇸United States smustgrave
So ran the test-only feature in gitlab and locally unfortunately passes even without the change to Attribute.php
Should the attribute variable call ->count() ?
- Status changed to Needs review
7 months ago 11:16am 12 June 2024 - 🇺🇸United States smustgrave
Re-ran again and the MR is still passing. Did you mean to push something up?
No I didn't push anything. In #14 i just explained the reason for using the current state of MR.
- 🇺🇸United States smustgrave
So currently test only feature is passing but should be failing. So not really sure what to do next here.
- Status changed to Needs work
7 months ago 6:42am 13 June 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
6 months ago 7:25am 18 June 2024 - Status changed to Needs work
6 months ago 8:32am 18 June 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India yash.rode pune
yash.rode → made their first commit to this issue’s fork.
- Status changed to Needs review
6 months ago 5:24am 19 June 2024 - 🇮🇳India yash.rode pune
#3445425-18: \Drupal\Core\Template\Attribute should implement Countable interface → is not true, the test is failing without the fix. Attached is a test only patch.
- last update
6 months ago Custom Commands Failed - 🇺🇸United States smustgrave
https://git.drupalcode.org/issue/drupal-3445425/-/jobs/1898662 shows it passing, ran locally it's passing
Not sure how much drupalCi is maintained but last option is for 10.1.x which doesn't apply here unfortunately.
- Status changed to Needs work
6 months ago 9:07am 8 July 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
