Check access in file.ajax_progress route

Created on 6 May 2024, 27 days ago
Updated 13 May 2024, 20 days ago

The path /file/progress/{key} is always available even for anonymous users. So if you navigate to /file/progress/test route you will end up with the following weird message.

{"message":"Starting upload...","percentage":-1}

I propose the route should return 403 or 404 when progress is not available for a given upload process.

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
File systemย  โ†’

Last updated 1 day ago

Created by

๐Ÿ‡ท๐Ÿ‡บRussia Chi

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Chi
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia kim.pepper ๐Ÿ„โ€โ™‚๏ธ๐Ÿ‡ฆ๐Ÿ‡บSydney, Australia

    kim.pepper โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Canceled
    20 days ago
    Total: 33s
    #171249
  • Pipeline finished with Canceled
    20 days ago
    Total: 76s
    #171250
  • Pipeline finished with Canceled
    20 days ago
    Total: 164s
    #171251
  • Status changed to Needs review 20 days ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia kim.pepper ๐Ÿ„โ€โ™‚๏ธ๐Ÿ‡ฆ๐Ÿ‡บSydney, Australia

    I think it's feasible that anonymous users would be able to see file upload progress, so I don't think it's an access thing. But I do agree we should check if the extension is enabled.

    Created a MR.

  • Pipeline finished with Failed
    20 days ago
    Total: 692s
    #171257
  • ๐Ÿ‡ท๐Ÿ‡บRussia Chi

    @kim.pepper

    Even if the extension is enabled the message `{"message":"Starting upload...","percentage":-1}` will still appear when no upload process is available.

  • Status changed to Needs work 20 days ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Can the issue summary be updated to match the standard template?

    See there is a test failure so maybe updating that will be enough coverage for the change being made.

Production build 0.69.0 2024