- Issue created by @nod_
- ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ made their first commit to this issueโs fork.
- Merge request !7921skip link offset added in case of navigation โ (Closed) created by Unnamed author
- ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ changed the visibility of the branch 3445274-navigation-module-offsets to hidden.
- ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ changed the visibility of the branch 3445274-navigation-module-offsets to active.
- Status changed to Needs review
about 1 month ago 6:05am 6 May 2024 - Status changed to Needs work
about 1 month ago 6:44am 6 May 2024 - Status changed to Needs review
about 1 month ago 12:57pm 6 May 2024 - Status changed to Needs work
about 1 month ago 1:45pm 7 May 2024 - ๐บ๐ธUnited States smustgrave
As a visual issue lets add before/after screenshots to the issue summary.
- Status changed to Needs review
about 1 month ago 1:54pm 7 May 2024 - ๐ฎ๐ณIndia Gauravvv Delhi, India
I have added before and after patch screenshot in issue summary.
- Status changed to Needs work
about 1 month ago 1:58pm 7 May 2024 - ๐บ๐ธUnited States smustgrave
Should be good practice
But before/after should be under User interface section
Also noticed that steps to reproduce and proposed resolution are empty. Other sections are probably fine.
- Status changed to Needs review
about 1 month ago 2:05pm 7 May 2024 - Status changed to RTBC
about 1 month ago 2:37pm 7 May 2024 - Status changed to Needs work
about 1 month ago 9:19pm 8 May 2024 - ๐ซ๐ทFrance nod_ Lille
This needs a default value for the css variable. If displace is not used on the page (no toolbar or navigation module) the skip link takes the whole width instead of the body width
- Status changed to Needs review
about 1 month ago 3:15am 9 May 2024 - Status changed to RTBC
about 1 month ago 1:43pm 9 May 2024 - Status changed to Fixed
about 1 month ago 11:38am 10 May 2024 - ๐ซ๐ทFrance nod_ Lille
Committed and pushed 7ac4979e2e to 11.x and ccc368e015 to 11.0.x and 26aafb10e3 to 10.4.x and cc27b4df99 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.