Navigation render array is completely generated, even if the navigation bar is not rendered

Moving to NR.

Instead of adding a pre_render callback, opted for adding a simple placeholder when user is not allowed to see the navigation bar because it's less intrusive with the LB render array generation process.

Since this marked major something we can get test coverage for?

It would be possible to write performance tests - i.e. that any extra queries/cache gets don't happen when the module is enabled for anonymous users, but I think that can be moved to a stable-blocking follow-up, rather than this which ought to block beta and is a simple change in itself. There's not really a way to test it other than performance testing because no user-facing bug.

Couldn't do a simple test calling the function to see if a render array is returned?

@smustgrave that's too specific - if we fixed it in the build method like earlier MRs on this issue, then calling the hook implementation directly would still get a render array, just not one that would render the toolbar unnecessarily.

Gotcha, opened 📌 Add test coverage Active and tagged as a navigation-stable-blocker (new tag)

This MR seems fine then with the early return.

Needs a rebase.

Code updated against 11.x

Rebase seems good.

Committed/pushed to 11.x, thanks!. Moving to 10.3.x for backport.

catch → closed merge request !7824

Automatically closed - issue fixed for 2 weeks with no activity.