- Issue created by @smustgrave
- πͺπΈSpain ckrina Barcelona
Hahah sorry @smustgrave I mean the other way around for the tag. Having one for the navigation will make things easier :D
- πͺπΈSpain ckrina Barcelona
Adding the "Drupal CMS release target" to see if we could hopefully get to it.
- First commit to issue fork.
- Merge request !10484Issue #3444152: Attempt a performance test for navigation_top_bar β (Open) created by m4olivei
- π¨π¦Canada m4olivei Grimsby, ON
I've never written a performance test before, so please, any feedback is welcome. I assumed what was meant by "performance test" was
\Drupal\FunctionalJavascriptTests\PerformanceTestBase
(see change record β ).The tests I've added will first get the home page to warm caches. Then delete caches and get the home page again, this time collecting performance data. We then install
navigation_top_bar
and repeat the process, comparing performance data before and after, expecting that we get the same numbers, eg.navigation_top_bar
does not impact performance. If top bar was mistakenly included for anonymous users, as was the case before the parent bug ticket was fixed, we'd see additional cache get/set afternavigation_top_bar
was enabled.At least that is what I think I did π . My work was inspired by
\Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest
. There wasn't any precedent that I could find in core for comparing before/after performance data like I'm doing here though. - πΊπΈUnited States smustgrave
Left some comments/questions on the MR
nice work!
- π¨π¦Canada m4olivei Grimsby, ON
Addressed comments. Ready for review again.