- Issue created by @mherchel
- 🇫🇷France nod_ Lille
raising to major since it interferes with the normal use of the site.
We should be looking at potentially splitting the font up to reduce size see https://github.com/zachleat/glyphhanger
- 🇺🇸United States mherchel Gainesville, FL, US
We should be looking at potentially splitting the font up to reduce size
💯💯💯
- First commit to issue fork.
- Merge request !7821Issue #3443915: Font for navigation is preloaded in header even when navigation bar is not loaded → (Open) created by plopesc
- Status changed to Needs review
7 months ago 7:10am 29 April 2024 - 🇪🇸Spain plopesc Valladolid
Good catch 💯
Added logic to include the font if only the toolbar is being rendered.
About font split. Do you think it has to be addressed here? Or might be moved to a lower priority follow up?
- 🇷🇸Serbia finnsky
We need to check it first:
https://github.com/zachleat/glyphhanger/issues/22To be sure that variable fonts supported. So i guess better to do it in separated ticket.
- 🇮🇳India Kanchan Bhogade
Hi,
I've tried to reproduce the issue on Drupal version 11.x
Please let me know if I've missed anything while reproducing the issueTesting steps:
- Install Drupal
- Install Navigation and Navigation Top bar Module
- and checked with an Anonymous user
Adding screenshot
- 🇷🇸Serbia finnsky
Just checked in last tugboat. Seems all fine
@Kanchan Bhogade probably cache?
- 🇺🇸United States mherchel Gainesville, FL, US
About font split. Do you think it has to be addressed here? Or might be moved to a lower priority follow up?
Definitely a followup. Probably needs a bit of discussion and maybe even testing.
- Status changed to RTBC
7 months ago 12:32pm 29 April 2024 - 🇺🇸United States mherchel Gainesville, FL, US
Thanks for working on this! Looks to be working as expected now. In addition to the administrator/anonymous screenshots below, I also created an authenticated user that doesn't have access to use the navigation bar and made sure the font wasn't loading for them.
Looks great!
- 🇺🇸United States mherchel Gainesville, FL, US
Opened followup: 📌 Navigation: Discuss/implement splitting variable font Active
- 🇬🇧United Kingdom catch
+1 on just moving the #attached['html_head_link'] this way, makes loads of sense.
- Status changed to Downport
7 months ago 1:23pm 29 April 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks! Moving to 10.3.x for backport with the rest of the navigation commits.
- Status changed to Fixed
7 months ago 9:30pm 29 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.